Skip to content

Reintroduce deprecated collections crate - #42720

Merged
bors merged 1 commit into
rust-lang:masterfrom
murarth:deprecated-collections
Jun 18, 2017
Merged

Reintroduce deprecated collections crate#42720
bors merged 1 commit into
rust-lang:masterfrom
murarth:deprecated-collections

Conversation

@murarth

@murarthmurarth commented Jun 17, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@murarth

murarth commented Jun 17, 2017

Copy link
Copy Markdown
ContributorAuthor

r? @alexcrichton

cc #42648

@murarth

murarth commented Jun 17, 2017

Copy link
Copy Markdown
ContributorAuthor

I added collections as a dependency to libstd without declaring extern crate collections; anywhere. It seemed to be the only way to get x.py to build libcollections.

@alexcrichton

alexcrichton commented Jun 17, 2017

Copy link
Copy Markdown
Member

@bors: r+

Thanks!

@bors

bors commented Jun 17, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 6f7c228 has been approved by alexcrichton

@Mark-SimulacrumMark-Simulacrum added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 17, 2017
@murarth

murarth commented Jun 17, 2017

Copy link
Copy Markdown
ContributorAuthor

Broken links strike again.

@Mark-Simulacrum

Mark-Simulacrum commented Jun 17, 2017

Copy link
Copy Markdown
Member

@bors r-

@Mark-SimulacrumMark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 17, 2017
@murarth

murarth commented Jun 17, 2017

Copy link
Copy Markdown
ContributorAuthor

Ah, it was because I forgot to re-export collections macros from alloc. Good thing that was caught somewhere.

@Mark-Simulacrum

Mark-Simulacrum commented Jun 17, 2017

Copy link
Copy Markdown
Member

@bors r=alexcrichton

@bors

bors commented Jun 17, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 6484258 has been approved by alexcrichton

@Mark-Simulacrum

Mark-Simulacrum commented Jun 18, 2017

Copy link
Copy Markdown
Member

@bors rollup

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 18, 2017
@Mark-Simulacrum
Rollup merge ofrust-lang#42720- murarth:deprecated-collections, r=a…
c982529
…lexcrichton
Reintroduce deprecated `collections` crate
@Mark-SimulacrumMark-Simulacrum mentioned this pull request Jun 18, 2017
Merged
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Jun 18, 2017
@frewsxcv
Rollup merge ofrust-lang#42720- murarth:deprecated-collections, r=a…
ff320a1
…lexcrichton
Reintroduce deprecated `collections` crate
@frewsxcvfrewsxcv mentioned this pull request Jun 18, 2017
Closed
bors added a commit that referenced this pull request Jun 18, 2017
@bors
Auto merge of#42738- Mark-Simulacrum:rollup, r=Mark-Simulacrum
247a018
Rollup of 7 pull requests
- Successful merges: #42695, #42714, #42720, #42723, #42730, #42731, #42734
- Failed merges: #42722
@bors
bors merged commit 6484258 into rust-lang:masterJun 18, 2017
@murarth
murarth deleted the deprecated-collections branch June 18, 2017 20:20
@PratyushPratyush mentioned this pull request Jun 20, 2017
Merged
@leoyvensleoyvens mentioned this pull request Oct 22, 2017
Merged
bors added a commit that referenced this pull request Oct 24, 2017
@bors
Auto merge of#45446- leodasvacas:remove-libcollections, r=alexcrichton
c2799fc
Remove deprecated `collections` crate.
The real `collections` was merged with `alloc`, this facade was introduced [in this PR](#42720) to give `#[no_std]` users time to adapt. This was done at least two cycles ago, now we can consider removing it for good.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichtonalexcrichton

Labels

S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@murarth@alexcrichton@bors@Mark-Simulacrum