Skip to content

Redox: Use create() instead of open() when setting env variable - #42783

Merged
bors merged 1 commit into
rust-lang:masterfrom
ids1024:redox-env
Jun 23, 2017
Merged

Redox: Use create() instead of open() when setting env variable#42783
bors merged 1 commit into
rust-lang:masterfrom
ids1024:redox-env

Conversation

@ids1024

@ids1024ids1024 commented Jun 20, 2017

Copy link
Copy Markdown
Contributor

@ids1024ids1024 closed this Jun 20, 2017
@rust-highfive

rust-highfive commented Jun 20, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @BurntSushi (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@ids1024ids1024 reopened this Jun 20, 2017
@alexcrichtonalexcrichton added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 22, 2017
@sfackler

sfackler commented Jun 22, 2017

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Jun 22, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 9f91a4d has been approved by sfackler

@bors

bors commented Jun 22, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 9f91a4d with merge 7ef2b7b...

bors added a commit that referenced this pull request Jun 22, 2017
@bors
Auto merge of#42783- ids1024:redox-env, r=sfackler
7ef2b7b
Redox: Use create() instead of open() when setting env variable
See https://github.com/redox-os/kernel/pull/25.
@bors

bors commented Jun 22, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@Mark-Simulacrum

Mark-Simulacrum commented Jun 22, 2017

Copy link
Copy Markdown
Member

Timeout on OS X.

@bors retry

@Mark-Simulacrum

Mark-Simulacrum commented Jun 22, 2017

Copy link
Copy Markdown
Member

@bors rollup

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 22, 2017
@Mark-Simulacrum
Rollup merge ofrust-lang#42783- ids1024:redox-env, r=sfackler
34d22cb
Redox: Use create() instead of open() when setting env variable
See https://github.com/redox-os/kernel/pull/25.
@Mark-SimulacrumMark-Simulacrum mentioned this pull request Jun 22, 2017
Closed
@Mark-SimulacrumMark-Simulacrum mentioned this pull request Jun 23, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 23, 2017
@Mark-Simulacrum
Rollup merge ofrust-lang#42783- ids1024:redox-env, r=sfackler
d22eb08
Redox: Use create() instead of open() when setting env variable
See https://github.com/redox-os/kernel/pull/25.
@Mark-SimulacrumMark-Simulacrum mentioned this pull request Jun 23, 2017
Merged
bors added a commit that referenced this pull request Jun 23, 2017
@bors
Auto merge of#42856- Mark-Simulacrum:rollup, r=Mark-Simulacrum
229d0d3
Rollup of 8 pull requests
- Successful merges: #42777, #42783, #42787, #42821, #42822, #42825, #42829, #42833
- Failed merges:
@bors
bors merged commit 9f91a4d into rust-lang:masterJun 23, 2017
@ids1024
ids1024 deleted the redox-env branch October 5, 2017 14:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@BurntSushiBurntSushi

Labels

S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ids1024@rust-highfive@sfackler@bors@Mark-Simulacrum@alexcrichton@BurntSushi