Skip to content

Update LLVM to fix unsigned multiplication overflow - #42828

Merged
bors merged 1 commit into
rust-lang:masterfrom
parched:umulo
Jun 23, 2017
Merged

Update LLVM to fix unsigned multiplication overflow#42828
bors merged 1 commit into
rust-lang:masterfrom
parched:umulo

Conversation

@parched

@parchedparched commented Jun 22, 2017

Copy link
Copy Markdown
Contributor

check for some targets, notably ARMv6-M.

Fixesrust-lang/compiler-builtins#150

James Duley
Update LLVM to fix unsigned multiplication overflow
7b4ff1c
check for some targets, notably ARMv6-M.
@rust-highfive

rust-highfive commented Jun 22, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton

alexcrichton commented Jun 22, 2017

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Jun 22, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 7b4ff1c has been approved by alexcrichton

@alexcrichtonalexcrichton added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 22, 2017
@bors

bors commented Jun 23, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 7b4ff1c with merge bd32b1b...

bors added a commit that referenced this pull request Jun 23, 2017
@bors
Auto merge of#42828- parched:umulo, r=alexcrichton
bd32b1b
Update LLVM to fix unsigned multiplication overflow
check for some targets, notably ARMv6-M.
Fixesrust-lang/compiler-builtins#150
@bors

bors commented Jun 23, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing bd32b1b to master...

@bors
bors merged commit 7b4ff1c into rust-lang:masterJun 23, 2017
This was referenced Jun 23, 2017
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@brsonbrson

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@parched@rust-highfive@alexcrichton@bors@brson