Uh oh!
There was an error while loading. Please reload this page.
Make sufficiently old or low-impact compatibility lints deny-by-default - #42894
Conversation
nikomatsakis
commented
Jun 27, 2017
Will start a crater run. |
Crater checklist:
|
nikomatsakis
commented
Jun 28, 2017
bors
commented
Jun 28, 2017
☔ The latest upstream changes (presumably #42417) made this pull request unmergeable. Please resolve the merge conflicts. |
petrochenkov
commented
Jun 29, 2017
spurious:
|
petrochenkov
commented
Jun 29, 2017
Looks like |
alexcrichton
commented
Jul 6, 2017
ping @petrochenkov just wanted to make sure this didn't fall off your radar |
nikomatsakis
commented
Jul 6, 2017
Just been out of town. Working on my backlog now! |
nikomatsakis
commented
Jul 7, 2017
@petrochenkov ok r=me when you feel this is ready to go |
petrochenkov
commented
Jul 7, 2017
I'm going to send patches to affected crates this weekend, after that I'll land this PR then. |
petrochenkov
commented
Jul 8, 2017
@bors r=nikomatsakis |
bors
commented
Jul 8, 2017
📌 Commit 9196f87 has been approved by |
bors
commented
Jul 8, 2017
Make sufficiently old or low-impact compatibility lints deny-by-default Needs crater run before proceeding. r? @nikomatsakis
Bump `clap` to fix the build on new versions of `rustc` (see [rust-lang/rust#42894](rust-lang/rust#42894) and [rust-lang/rust#40107](rust-lang/rust#40107) for details)
bors
commented
Jul 8, 2017
☀️ Test successful - status-appveyor, status-travis |
resolve: Reduce scope of `pub_use_of_private_extern_crate` deprecation lint This lint was deny-by-default since July 2017, crater showed 7 uses on crates.io back then (rust-lang#42894 (comment)). Unfortunately, the construction `pub use foo as bar` where `foo` is `extern crate foo;` was used by an older version `bitflags`, so turning it into an error causes too many regressions. So, this PR reduces the scope of the lint instead of turning it into a hard error, and only turns some more rarely used components of it into errors.
resolve: Reduce scope of `pub_use_of_private_extern_crate` deprecation lint This lint was deny-by-default since July 2017, crater showed 7 uses on crates.io back then (rust-lang#42894 (comment)). Unfortunately, the construction `pub use foo as bar` where `foo` is `extern crate foo;` was used by an older version `bitflags`, so turning it into an error causes too many regressions. So, this PR reduces the scope of the lint instead of turning it into a hard error, and only turns some more rarely used components of it into errors.
resolve: Reduce scope of `pub_use_of_private_extern_crate` deprecation lint This lint was deny-by-default since July 2017, crater showed 7 uses on crates.io back then (rust-lang#42894 (comment)). Unfortunately, the construction `pub use foo as bar` where `foo` is `extern crate foo;` was used by an older version `bitflags`, so turning it into an error causes too many regressions. So, this PR reduces the scope of the lint instead of turning it into a hard error, and only turns some more rarely used components of it into errors.
resolve: Reduce scope of `pub_use_of_private_extern_crate` deprecation lint This lint was deny-by-default since July 2017, crater showed 7 uses on crates.io back then (rust-lang#42894 (comment)). Unfortunately, the construction `pub use foo as bar` where `foo` is `extern crate foo;` was used by an older version `bitflags`, so turning it into an error causes too many regressions. So, this PR reduces the scope of the lint instead of turning it into a hard error, and only turns some more rarely used components of it into errors.
resolve: Reduce scope of `pub_use_of_private_extern_crate` deprecation lint This lint was deny-by-default since July 2017, crater showed 7 uses on crates.io back then (rust-lang#42894 (comment)). Unfortunately, the construction `pub use foo as bar` where `foo` is `extern crate foo;` was used by an older version `bitflags`, so turning it into an error causes too many regressions. So, this PR reduces the scope of the lint instead of turning it into a hard error, and only turns some more rarely used components of it into errors.
cc #39216
cc #36247
cc #37872
cc #38260
cc #40107
cc #42238
Needs crater run before proceeding.
r? @nikomatsakis