Skip to content

Clone submodules recursively - #42928

Closed
ishitatsuyuki wants to merge 1 commit into
rust-lang:masterfrom
ishitatsuyuki:subm-r
Closed

Clone submodules recursively#42928
ishitatsuyuki wants to merge 1 commit into
rust-lang:masterfrom
ishitatsuyuki:subm-r

Conversation

@ishitatsuyuki

@ishitatsuyukiishitatsuyuki commented Jun 27, 2017

Copy link
Copy Markdown
Contributor

Partially for #42911
Not deeply tested.

@rust-highfive

rust-highfive commented Jun 27, 2017

Copy link
Copy Markdown
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@ishitatsuyuki

ishitatsuyuki commented Jun 27, 2017

Copy link
Copy Markdown
ContributorAuthor

r? @nrc

@rust-highfiverust-highfive assigned nrc and unassigned aturonJun 27, 2017
@frewsxcvfrewsxcv added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Jun 27, 2017
@nagisa

nagisa commented Jun 27, 2017

Copy link
Copy Markdown
Member

This is also done by #42899, which seems like it is likely to be r+d fairly soon.

@Mark-SimulacrumMark-Simulacrum mentioned this pull request Jun 27, 2017
Merged
@Mark-Simulacrum

Mark-Simulacrum commented Jun 27, 2017

Copy link
Copy Markdown
Member

Well, partially. I'm going to leave a comment there mentioning that the init_repo script needs updating as well

@nrc

nrc commented Jun 27, 2017

Copy link
Copy Markdown
Member

r? @alexcrichton

I've undone the submodule stuff in the RLS, so this is not necessary for the RLS now, but it might be good to have anyway?

@arielb1arielb1 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 27, 2017
@alexcrichton

alexcrichton commented Jun 27, 2017

Copy link
Copy Markdown
Member

r? @aidanhs

@aidanhs

aidanhs commented Jun 27, 2017

Copy link
Copy Markdown
Contributor

I'm pretty confident this is going to be superseded by #42899 per #42899 (comment), but I really appreciate you raising this PR @ishitatsuyuki because it's provided a useful hint for what we need to change in init_repo.sh.

I'll close this PR if appropriate when the other one gets merged.

@bors

bors commented Jul 2, 2017

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #43003) made this pull request unmergeable. Please resolve the merge conflicts.

@aidanhs

aidanhs commented Jul 6, 2017

Copy link
Copy Markdown
Contributor

This has been merged as part of #42899. Thanks again @ishitatsuyuki!

@aidanhsaidanhs closed this Jul 6, 2017
@ishitatsuyuki
ishitatsuyuki deleted the subm-r branch July 6, 2017 12:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aidanhsaidanhsAwaiting requested review from aidanhs

Assignees

@aidanhsaidanhs

Labels

S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@ishitatsuyuki@rust-highfive@nagisa@Mark-Simulacrum@nrc@alexcrichton@aidanhs@bors@frewsxcv@aturon@arielb1