Skip to content

Rollup of 4 pull requests - #42978

Closed
frewsxcv wants to merge 12 commits into
rust-lang:masterfrom
frewsxcv:rollup
Closed

Rollup of 4 pull requests#42978
frewsxcv wants to merge 12 commits into
rust-lang:masterfrom
frewsxcv:rollup

Conversation

@frewsxcv

@frewsxcvfrewsxcv commented Jun 30, 2017

Copy link
Copy Markdown
Contributor

tbu-and others added 12 commits June 27, 2017 12:09
@tbu-
Document possible io::ErrorKinds of fs::open
71252d9
Try to make clear that this isn't an API guarantee for now, as we likely
want to refine these errors in the future, e.g. `ENOSPC` "No space left
on device".
CC rust-lang#40322
Nick Cameron
Update RLS submodule
3dad197
@tbu-
Add links to the ErrorKind variants in errors of open
2783d0f
@cengiz-io
use PAGER to view --explain outputrust-lang#32665
ccfa9c4
@cengiz-io
do not append an extra newline char
f8aad9d
@cengiz-io
use unwrap_or_else to prevent unnecessary alloc
d2a0ead
@GuillaumeGomez
Add E0619 error explanation
76d54c0
@GuillaumeGomez
Fix error codes mixup
2c86ff4
@frewsxcv
Rollup merge ofrust-lang#42732- cengizIO:master, r=Mark-Simulacrum
c025202
Add pager support for `rustc --explain EXXXX`
Hello!
This is my take on rust-lang#32665.
Thanks!
**EDIT:** _I've limited access to a Windows machine so this is taking longer than I've anticipated_. 🐢
cc @alexcrichton@nikomatsakis@Mark-Simulacrum@retep998@ollie27@afiune
@frewsxcv
Rollup merge ofrust-lang#42911- nrc:rls-update, r=brson
7e22875
Update RLS submodule
@frewsxcv
Rollup merge ofrust-lang#42925- tbu-:pr_document_file_open_errors, …
217bd32
…r=GuillaumeGomez
Document possible `io::ErrorKind`s of `fs::open`
Try to make clear that this isn't an API guarantee for now, as we likely
want to refine these errors in the future, e.g. `ENOSPC` "No space left
on device".
CC rust-lang#40322
@frewsxcv
Rollup merge ofrust-lang#42957- GuillaumeGomez:add-e0619, r=nikomat…
dea34bd
…sakis
Add E0619 error explanation
r? @eddyb
@rust-highfive

rust-highfive commented Jun 30, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv

frewsxcv commented Jun 30, 2017

Copy link
Copy Markdown
ContributorAuthor

@bors r+ rollup

@bors

bors commented Jun 30, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit dea34bd has been approved by frewsxcv

@frewsxcv

frewsxcv commented Jun 30, 2017

Copy link
Copy Markdown
ContributorAuthor

@bors p=10

@frewsxcv

frewsxcv commented Jun 30, 2017

Copy link
Copy Markdown
ContributorAuthor

@bors rollup-

@bors

bors commented Jun 30, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit dea34bd with merge 3da4baaa2c1a8bd6bf3977fe24e7633b9c1deda9...

@bors

bors commented Jun 30, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-appveyor

@kennytm

kennytm commented Jun 30, 2017

Copy link
Copy Markdown
Member

Legit? Trailing line in UI test ui/explain.rs. #42732.

@CentrilCentril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@arielb1arielb1

Labels

rollupA PR which is a rollup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@frewsxcv@rust-highfive@bors@kennytm@Centril@arielb1@Mark-Simulacrum@tbu-@cengiz-io@GuillaumeGomez