Skip to content

Rollup of 4 pull requests - #42989

Closed
GuillaumeGomez wants to merge 28 commits into
rust-lang:masterfrom
GuillaumeGomez:rollup
Closed

Rollup of 4 pull requests#42989
GuillaumeGomez wants to merge 28 commits into
rust-lang:masterfrom
GuillaumeGomez:rollup

Conversation

tbu-and others added 28 commits June 27, 2017 12:09
Try to make clear that this isn't an API guarantee for now, as we likely
want to refine these errors in the future, e.g. `ENOSPC` "No space left
on device".
CC rust-lang#40322
Adding diagnostic code 0611 for lifetime errors with one named, one anonymous lifetime parameter
This is a fix for rust-lang#42517
Note that this only handles the above case for **function declarations** and **traits**.
`impl items` and `closures` will be handled in a later PR.
Example
```
fn foo<'a>(x: &i32, y: &'a i32) -> &'a i32 {
if x > y { x } else { y }
}
```
now displays the following error message. ui tests have been added for the same.
```
error[E0611]: explicit lifetime required in the type of `x`
11 | fn foo<'a>(x: &i32, y: &'a i32) -> &'a i32 {
| ^ consider changing the type of `x` to `&'a i32`
12 | if x > y { x } else { y }
| - lifetime `'a` required
```
rust-lang#42516
r? @nikomatsakis
Add pager support for `rustc --explain EXXXX`
Hello!
This is my take on rust-lang#32665.
Thanks!
**EDIT:** _I've limited access to a Windows machine so this is taking longer than I've anticipated_. 🐢
cc @alexcrichton@nikomatsakis@Mark-Simulacrum@retep998@ollie27@afiune
…r=GuillaumeGomez
Document possible `io::ErrorKind`s of `fs::open`
Try to make clear that this isn't an API guarantee for now, as we likely
want to refine these errors in the future, e.g. `ENOSPC` "No space left
on device".
CC rust-lang#40322
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@CentrilCentril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rollupA PR which is a rollup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@GuillaumeGomez@rust-highfive@eddyb@Centril@tbu-@gaurikholkar@nikomatsakis@cengiz-io