Uh oh!
There was an error while loading. Please reload this page.
Stabilize float_bits_conv for Rust 1.20 - #43055
Merged
Merged
Conversation
est31force-pushed
the
stabilize_float_bits_conv
branch
from
July 6, 2017 13:14
b98547b to
9fb16a6Compareest31
commented
Jul 6, 2017
MemberAuthor
I guess the 1.20 estimate is wrong because of the FCP which delays by >= 10 days and the new beta branches in a week already. 1.21 it is then! |
est31force-pushed
the
stabilize_float_bits_conv
branch
from
July 6, 2017 13:17
9fb16a6 to
010dea1Comparecarols10cents
commented
Jul 10, 2017
Member
friendly ping @BurntSushi! |
BurntSushi
commented
Jul 10, 2017
Member
Doesn't FCP in #40470 need to finish first? |
carols10cents
commented
Jul 10, 2017
Member
Oh sorry, that wasn't clear in this issue. |
seppalai
commented
Jul 13, 2017
Is there any way to work around this in Rust 1.18? |
MemberAuthor
@i-dash what do you mean by that? Right now its possible to do such conversion with the help of unsafe Rust. Or have you stumbled into huonw/ieee754#2 ? For that, you can use a cargo replace, like doing the following in your Cargo.toml (maybe you need to adjust the version, also untested): [replace]
"ieee754:0.2.1" = { git = "https://github.com/clarcharr/ieee754" } |
est31
commented
Jul 16, 2017
MemberAuthor
r? @BurntSushi |
sfackler
commented
Jul 17, 2017
Member
@bors r+ rollup |
bors
commented
Jul 17, 2017
Collaborator
📌 Commit 010dea1 has been approved by |
bors
commented
Jul 17, 2017
Collaborator
bors added a commit
that referenced
this pull request
Jul 17, 2017
Stabilize float_bits_conv for Rust 1.21 Stabilizes the `float_bits_conv` lib feature for the 1.20 release of Rust. I've initially implemented the feature in #39271 and later made PR #43025 to output quiet NaNs even on platforms with different encodings, which seems to have been the only unresolved issue of the API. Due to PR #43025 being only applied to master this stabilisation can't happen for Rust 1.19 through the usual "stabilisation on beta" system that is being done for library APIs. r? @BurntSushicloses#40470.
bors
commented
Jul 17, 2017
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stabilizes the
float_bits_convlib feature for the 1.20 release of Rust. I've initially implemented the feature in #39271 and later made PR #43025 to output quiet NaNs even on platforms with different encodings, which seems to have been the only unresolved issue of the API.Due to PR #43025 being only applied to master this stabilisation can't happen for Rust 1.19 through the usual "stabilisation on beta" system that is being done for library APIs.
r? @BurntSushi
closes#40470.