Uh oh!
There was an error while loading. Please reload this page.
rustdoc: Don't run Markdown tests twice - #43068
Merged
Merged
Conversation
GuillaumeGomez
commented
Jul 6, 2017
Member
Good catch, thanks! @bors: r+ |
bors
commented
Jul 6, 2017
Collaborator
📌 Commit dec01f8 has been approved by |
bors
commented
Jul 6, 2017
Collaborator
🔒 Merge conflict |
This matches the behaviour for finding tests in Rust files.
ollie27force-pushed
the
rustdoc_markdown_tests
branch
from
July 6, 2017 15:49
dec01f8 to
1966a67Compareollie27
commented
Jul 6, 2017
ContributorAuthor
rebased |
GuillaumeGomez
commented
Jul 6, 2017
Member
@bors: r+ |
bors
commented
Jul 6, 2017
Collaborator
📌 Commit 1966a67 has been approved by |
bors
commented
Jul 7, 2017
Collaborator
bors added a commit
that referenced
this pull request
Jul 7, 2017
rustdoc: Don't run Markdown tests twice This matches the behaviour for finding tests in Rust files. This was a regression from 1.17 to 1.18 so it would be a good idea to backport this to beta so at least 1.19 won't also be affected. Fixes#42726 r? @GuillaumeGomez
bors
commented
Jul 7, 2017
Collaborator
☀️ Test successful - status-appveyor, status-travis |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matches the behaviour for finding tests in Rust files.
This was a regression from 1.17 to 1.18 so it would be a good idea to backport this to beta so at least 1.19 won't also be affected.
Fixes#42726
r? @GuillaumeGomez