Skip to content

Store all generic arguments for method calls in AST/HIR - #43115

Merged
bors merged 3 commits into
rust-lang:masterfrom
petrochenkov:methlife2
Jul 9, 2017
Merged

Store all generic arguments for method calls in AST/HIR#43115
bors merged 3 commits into
rust-lang:masterfrom
petrochenkov:methlife2

Conversation

@petrochenkov

@petrochenkovpetrochenkov commented Jul 8, 2017

Copy link
Copy Markdown
Contributor

The first part of #42492.
Landed separately to start the process of merging libsyntax changes breaking rustfmt, which is not easy these days.

@rust-highfiverust-highfive assigned pnkfelix and unassigned eddybJul 8, 2017
@rust-highfive

rust-highfive commented Jul 8, 2017

Copy link
Copy Markdown
Contributor

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@petrochenkov

petrochenkov commented Jul 8, 2017

Copy link
Copy Markdown
ContributorAuthor

@bors r=eddyb
(#42492 (comment))

@bors

bors commented Jul 8, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 31c8f7c has been approved by eddyb

@petrochenkovpetrochenkov mentioned this pull request Jul 8, 2017
Merged
@bors

bors commented Jul 8, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 31c8f7c4f93998e6090e1f86229ca263cad5519a with merge df78f1a76f512728aa51c4345ead1cac26d46a82...

@bors

bors commented Jul 8, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-appveyor

@petrochenkov

petrochenkov commented Jul 8, 2017

Copy link
Copy Markdown
ContributorAuthor

Looks spurious.
@bors retry

@bors

bors commented Jul 9, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 31c8f7c4f93998e6090e1f86229ca263cad5519a with merge 3934cc85da94a14bbf66f31b92b977f9b6956b42...

@bors

bors commented Jul 9, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@petrochenkov

petrochenkov commented Jul 9, 2017

Copy link
Copy Markdown
ContributorAuthor

RLS build fails on PowerPC with unresolved import `std::sync::atomic::AtomicU64` due to rust-lang/rls@7029815

@petrochenkovpetrochenkov mentioned this pull request Jul 9, 2017
Closed
@petrochenkov

petrochenkov commented Jul 9, 2017

Copy link
Copy Markdown
ContributorAuthor

@bors r=eddyb

@bors

bors commented Jul 9, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 9ac79e4 has been approved by eddyb

@bors

bors commented Jul 9, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 9ac79e4 with merge d84693b...

bors added a commit that referenced this pull request Jul 9, 2017
@bors
Auto merge of#43115- petrochenkov:methlife2, r=eddyb
d84693b
Store all generic arguments for method calls in AST/HIR
The first part of #42492.
Landed separately to start the process of merging libsyntax changes breaking rustfmt, which is not easy these days.
@bors

bors commented Jul 9, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing d84693b to master...

@borsbors mentioned this pull request Jul 9, 2017
Merged
@bors
bors merged commit 9ac79e4 into rust-lang:masterJul 9, 2017
@petrochenkovpetrochenkov mentioned this pull request Jul 9, 2017
Merged
This was referenced Jul 9, 2017
Merged
Merged
@borsbors mentioned this pull request Jul 9, 2017
Merged
@petrochenkovpetrochenkov mentioned this pull request Jul 21, 2017
Merged
@petrochenkov
petrochenkov deleted the methlife2 branch August 26, 2017 00:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@pnkfelixpnkfelix

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@petrochenkov@rust-highfive@bors@eddyb@pnkfelix