Uh oh!
There was an error while loading. Please reload this page.
Implement fs::rename in sys::redox - #43204
Merged
Merged
Conversation
rust-highfive
commented
Jul 13, 2017
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
durka
reviewed
Jul 13, 2017
| @@ -384,8 +384,9 @@ pub fn unlink(p: &Path) -> io::Result<()> { | |||
| } | |||
| pub fn rename(_old: &Path, _new: &Path) -> io::Result<()> { | |||
Contributor
There was a problem hiding this comment.
you forgot to rename the arguments
codyps
reviewed
Jul 13, 2017
| unimplemented!(); | ||
| copy(old, new)?; | ||
| unlink(old)?; | ||
| Ok(()) |
Contributor
There was a problem hiding this comment.
The 2 proceeding lines could be reduced to unlink(old)
alexcrichton
commented
Jul 13, 2017
Member
@bors: r+ rollup |
bors
commented
Jul 13, 2017
Collaborator
📌 Commit 4259ae6 has been approved by |
jackpot51
commented
Jul 13, 2017
ContributorAuthor
Thanks! |
steveklabnik added a commit
to steveklabnik/rust
that referenced
this pull request
Jul 13, 2017
Implement fs::rename in sys::redox This uses a simple implementation of copy + unlink. Redox does not have a rename or link system call for a faster implementation.
bors added a commit
that referenced
this pull request
Jul 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses a simple implementation of copy + unlink. Redox does not have a rename or link system call for a faster implementation.