Improve panic docs for Instant::duration_since by Others · Pull Request #43256 · rust-lang/rust

Others · 2017-07-15T20:23:35Z

The docs for Instant::duration_since has a confusing section on panicking. It's
much more clear without the second two sentences of description.

The docs for Instant::duration_since has a confusing section on panicking. It's much more clear without the second two sentences of description.

rust-highfive · 2017-07-15T20:23:48Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @sfackler (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

sfackler · 2017-07-15T21:08:34Z

r? @steveklabnik

steveklabnik · 2017-07-18T22:24:57Z

@bors: r+

agreed, thanks!

bors · 2017-07-18T22:24:58Z

📌 Commit c458627 has been approved by steveklabnik

arielb1 · 2017-07-18T22:28:53Z

@bors rollup

bors · 2017-07-19T09:24:18Z

⌛ Testing commit c458627 with merge c57adc276eec266c41e605ad85fbde7198aeab73...

bors · 2017-07-19T09:28:35Z

💔 Test failed - status-appveyor

nagbot-rs · 2017-07-19T14:12:55Z

@bors: retry

…

On Wed, Jul 19, 2017 at 4:28 AM, bors ***@***.***> wrote: 💔 Test failed - status-appveyor <https://ci.appveyor.com/project/rust-lang/rust/build/1.0.3978> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#43256 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AaPN0N-evhBDPAJHkoDna3TKENKqBZJwks5sPcxUgaJpZM4OZHfP> . -- You received this message because you are subscribed to the Google Groups "rust-ops" group. To unsubscribe from this group and stop receiving emails from it, send an email to ***@***.*** To post to this group, send email to ***@***.*** To view this discussion on the web visit https://groups.google.com/d/ msgid/rust-ops/rust-lang/rust/pull/43256/c316327379%40github.com <https://groups.google.com/d/msgid/rust-ops/rust-lang/rust/pull/43256/c316327379%40github.com?utm_medium=email&utm_source=footer> . For more options, visit https://groups.google.com/d/optout.

bors · 2017-07-19T14:12:57Z

@nagbot-rs: 🔑 Insufficient privileges: and not in try users

alexcrichton · 2017-07-19T14:14:11Z

@bors: retry

bors · 2017-07-21T11:34:13Z

⌛ Testing commit c458627 with merge 5ba271e42032f53fe7f92fa2c091c1e9a736519f...

bors · 2017-07-21T12:04:09Z

💔 Test failed - status-travis

TimNN · 2017-07-21T14:23:57Z

@bors retry

Spurious network failure, that seems to have fixed itself

Improve panic docs for Instant::duration_since The docs for Instant::duration_since has a confusing section on panicking. It's much more clear without the second two sentences of description.

Rollup of 8 pull requests - Successful merges: #43046, #43256, #43280, #43297, #43313, #43319, #43322, #43343 - Failed merges:

bors · 2017-07-23T09:26:57Z

⌛ Testing commit c458627 with merge 3cf2c04...

Improve panic docs for Instant::duration_since The docs for Instant::duration_since has a confusing section on panicking. It's much more clear without the second two sentences of description.

bors · 2017-07-23T11:54:54Z

☀️ Test successful - status-appveyor, status-travis
Approved by: steveklabnik
Pushing 3cf2c04 to master...

Improve panic docs for Instant::duration_since
c458627
The docs for Instant::duration_since has a confusing section on panicking. It's much more clear without the second two sentences of description.

rust-highfive assigned sfackler Jul 15, 2017

rust-highfive assigned steveklabnik and unassigned sfackler Jul 15, 2017

Mark-Simulacrum added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 17, 2017

arielb1 added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2017

TimNN mentioned this pull request Jul 21, 2017
Rollup of 8 pull requests #43388
Closed

bors added a commit that referenced this pull request Jul 21, 2017
Auto merge of#43388- TimNN:rollup, r=TimNN
bf51b85
Rollup of 8 pull requests - Successful merges: #43046, #43256, #43280, #43297, #43313, #43319, #43322, #43343 - Failed merges:

bors merged commit c458627 into rust-lang:masterJul 23, 2017

Uh oh!

Uh oh!

Conversation

Others commented Jul 15, 2017

Uh oh!

rust-highfive commented Jul 15, 2017

Uh oh!

sfackler commented Jul 15, 2017

Uh oh!

steveklabnik commented Jul 18, 2017

Uh oh!

bors commented Jul 18, 2017

Uh oh!

arielb1 commented Jul 18, 2017

Uh oh!

bors commented Jul 19, 2017

Uh oh!

bors commented Jul 19, 2017

Uh oh!

nagbot-rs commented Jul 19, 2017 via email

Uh oh!

bors commented Jul 19, 2017

Uh oh!

alexcrichton commented Jul 19, 2017

Uh oh!

bors commented Jul 21, 2017

Uh oh!

bors commented Jul 21, 2017

Uh oh!

TimNN commented Jul 21, 2017

Uh oh!

bors commented Jul 23, 2017

Uh oh!

bors commented Jul 23, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants