Uh oh!
There was an error while loading. Please reload this page.
Attempt to fix appveyor - #43333
Merged
Merged
Conversation
alexcrichton
commented
Jul 19, 2017
Member
AFAIK revocation is on by default for Windows but not elsewhere, see rust-lang/cargo#3699 Can you add a comment to this? Otherwise r=me |
Mark-Simulacrumforce-pushed
the
appveyor-fix
branch
from
July 19, 2017 13:35
b382ec7 to
bbe0250CompareMark-Simulacrum
commented
Jul 19, 2017
MemberAuthor
@bors r=alexcrichton |
bors
commented
Jul 19, 2017
Collaborator
📌 Commit bbe0250 has been approved by |
bors
commented
Jul 19, 2017
Collaborator
⌛ Testing commit bbe025027c281e1f0e8b7abc42975f7beb75b41c with merge 4d335bed12f3da18c866a7d3846633699bae9806... |
bors
commented
Jul 19, 2017
Collaborator
💔 Test failed - status-appveyor |
Mark-Simulacrum
commented
Jul 19, 2017
MemberAuthor
hm... So I get the following locally (sorry for screenshot, not sure how to hook clipboard to VM). Not sure what to do here...
|
alexcrichton
commented
Jul 19, 2017
Member
@bors: r+ |
bors
commented
Jul 19, 2017
Collaborator
📌 Commit 3fe5721 has been approved by |
bors
commented
Jul 19, 2017
Collaborator
bors added a commit
that referenced
this pull request
Jul 19, 2017
Attempt to fix appveyor This will fix the problem, I think, but I don't know that this is a good idea (potentially leaving ourselves open to attackers, I guess, if a cert was revoked...). Of course, it may not. I don't actually have windows to check on.. r? @alexcrichton
This was referenced Jul 19, 2017
bors
commented
Jul 19, 2017
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix the problem, I think, but I don't know that this is a good idea (potentially leaving ourselves open to attackers, I guess, if a cert was revoked...). Of course, it may not. I don't actually have windows to check on..
r? @alexcrichton