Uh oh!
There was an error while loading. Please reload this page.
Update Rust LLVM bindings for LLVM 5.0 - #43387
Conversation
rust-highfive
commented
Jul 21, 2017
(rust_highfive has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
This field is no longer used. I left it for the moment in case it is needed again in the future, however I can remove it if desired.
There was a problem hiding this comment.
Eh seems fine to me to go ahead and remove
There was a problem hiding this comment.
This is what the go bindings do, I don't know if we want the ability to set this from rust? Even if so I guess it currently isn't used so that functionality can be added later if desired.
shepmaster
commented
Jul 21, 2017
When I helped with the last upgrade, we were able to drop the support for the oldest version of LLVM. I'm not sure what the policy is there, or if would even help, but just as a FYI. |
TimNN
commented
Jul 21, 2017
Mh, I think the oldest we still support is 3.9 and AFAIK we'll continue to support that for some time. |
TimNN
commented
Jul 21, 2017
Updated with the attributes changes from @alexcrichton from TimNN#1, thanks a lot! |
alexcrichton
commented
Jul 21, 2017
alexcrichton
commented
Jul 21, 2017
@TimNN want to throw in alexcrichton@b3e91ec which should fix archive creation as well? |
alexcrichton
commented
Jul 21, 2017
All looks great to me! Feel free to r=me once it's working locally for you |
alexcrichton
commented
Jul 21, 2017
@bors: r+ I believe this covers at least all the rustllvm stuff at least! |
bors
commented
Jul 21, 2017
📌 Commit fb217af has been approved by |
alexcrichton
commented
Jul 21, 2017
@bors: r+ |
bors
commented
Jul 21, 2017
📌 Commit 38e40ce has been approved by |
bors
commented
Jul 23, 2017
Update Rust LLVM bindings for LLVM 5.0 This is the initial set of changes to update the rust llvm bindings for 5.0. The llvm commits necessitating these changes are linked from the tracking issue, #43370.
bors
commented
Jul 23, 2017
☀️ Test successful - status-appveyor, status-travis |
This is the initial set of changes to update the rust llvm bindings for 5.0. The llvm commits necessitating these changes are linked from the tracking issue, #43370.