Uh oh!
There was an error while loading. Please reload this page.
Thread through the original error when opening archives - #43389
Merged
Conversation
This updates the management of opening archives to thread through the original piece of error information from LLVM over to the end consumer, trans.
rust-highfive
commented
Jul 21, 2017
Contributor
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
commented
Jul 27, 2017
MemberAuthor
Mind taking over the review from @pnkfelix who I think's on PTO? |
michaelwoerister
commented
Jul 31, 2017
Member
@bors r+ rollup |
bors
commented
Jul 31, 2017
Collaborator
📌 Commit 81eea9e has been approved by |
bors
commented
Jul 31, 2017
Collaborator
bors added a commit
that referenced
this pull request
Jul 31, 2017
Thread through the original error when opening archives This updates the management of opening archives to thread through the original piece of error information from LLVM over to the end consumer, trans.
carols10cents
commented
Jul 31, 2017
Member
friendly ping for review @michaelwoerister ! pinging you on IRC too! |
carols10cents
commented
Jul 31, 2017
Member
oops sorry github hadn't reloaded this tab ignore me |
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Aug 2, 2017
…lwoerister Thread through the original error when opening archives This updates the management of opening archives to thread through the original piece of error information from LLVM over to the end consumer, trans.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the management of opening archives to thread through the original
piece of error information from LLVM over to the end consumer, trans.