Uh oh!
There was an error while loading. Please reload this page.
add a note to Vec's Extend<&T> impl about its slice specialization - #43455
Merged
Conversation
rust-highfive
commented
Jul 24, 2017
Contributor
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
QuietMisdreavus
commented
Jul 24, 2017
ContributorAuthor
r? @rust-lang/docs |
carols10cents
commented
Jul 24, 2017
Member
I don't think highfive understands teams yet, sooooo |
QuietMisdreavus
commented
Jul 24, 2017
ContributorAuthor
@carols10cents Yeah, it was mainly to just ping the team as a whole, and stick it on whoever checked their email first |
There was a problem hiding this comment.
Missing url for copy_from_slice.
steveklabnik
commented
Jul 25, 2017
Contributor
r=me after said URL is added |
QuietMisdreavusforce-pushed
the
extend-spec-docs
branch
from
July 25, 2017 15:55
6d6808a to
6e36769CompareQuietMisdreavus
commented
Jul 25, 2017
ContributorAuthor
Updated. I ran linkchecker locally and it worked just fine, but i'll wait for travis all the same. |
QuietMisdreavus
commented
Jul 25, 2017
ContributorAuthor
@bors r=steveklabnik rollup |
bors
commented
Jul 25, 2017
Collaborator
📌 Commit 6e36769 has been approved by |
Mark-Simulacrum added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Jul 26, 2017
…=steveklabnik add a note to Vec's Extend<&T> impl about its slice specialization From the regular documentation view, it's not at all apparent that [this specialization](https://github.com/rust-lang/rust/blob/5669c9988f50788b5ab5dee2d4538519d4e5663d/src/liballoc/vec.rs#L1879-L1891) exists for `slice::Iter`. This adds a documentation blurb to the Extend impl itself to note that this optimization exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the regular documentation view, it's not at all apparent that this specialization exists for
slice::Iter. This adds a documentation blurb to the Extend impl itself to note that this optimization exists.