Uh oh!
There was an error while loading. Please reload this page.
Build rustdoc only at the topmost stage. - #43528
Closed
Mark-Simulacrum wants to merge 1 commit into
Closed
Conversation
This effectively ensures that rustdoc will only ever be built once for any given host. This does not introduce cycles into the build since we only depend on rustdoc from documentation or test steps, which run after the required compiler was built.
rust-highfive
commented
Jul 28, 2017
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
Mark-Simulacrum
commented
Jul 28, 2017
MemberAuthor
alexcrichton
commented
Jul 28, 2017
Member
@bors: r+ |
bors
commented
Jul 28, 2017
Collaborator
📌 Commit ff2f7c5 has been approved by |
Mark-Simulacrum
commented
Jul 29, 2017
MemberAuthor
Hm, I actually want to run some more tests on this before we land it. I worry that it might break testing stage1 std, but am uncertain. @bors r- |
shepmaster
commented
Aug 4, 2017
Member
@Mark-Simulacrum This is your friendly 7-day ping for activity! |
Mark-Simulacrum
commented
Aug 4, 2017
MemberAuthor
Closing in favor of #43630. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This effectively ensures that rustdoc will only ever be built once for
any given host. This does not introduce cycles into the build since we
only depend on rustdoc from documentation or test steps, which run after
the required compiler was built.
I've tested locally and
./x.py doc --stage 1 src/libstddoes not build more than all stage0 artifacts and stage1 libstd.I'm not entirely sure that this will work, but I think it should. We'll see if Travis passes.