Uh oh!
There was an error while loading. Please reload this page.
Make backtraces work on Redox, copying Unix implementation - #43635
Conversation
…config.git This is needed for it to compile on Redox.
rust-highfive
commented
Aug 4, 2017
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
| #[cfg(any(target_os = "macos", target_os = "ios", | ||
| target_os = "emscripten"))] | ||
| #[path = "dladdr.rs"] |
There was a problem hiding this comment.
Redox is never macos, so no need for dladdr.rs
There was a problem hiding this comment.
True; I thought it might be best not to modify those files too much (I just changed get_executable_filename in mod.rs) so they can be easily synced with the Unix version, but otherwise several things could be removed.
The duplicated code is somewhat annoying; I don't think it's avoidable though.
There was a problem hiding this comment.
I guess (multiple) entire files that are useless is probably a waste, so I've pushed a commit addressing this.
arielb1
commented
Aug 8, 2017
ping @brson - be our rubber stamp |
jackpot51
commented
Aug 11, 2017
@brson@arielb1@shepmaster Any updates on this? |
alexcrichton
commented
Aug 15, 2017
Thanks @ids1024! Out of curiosity, where'd the changes to |
ids1024
commented
Aug 15, 2017
I could change the Future releases of libbacktrace will probably have that fix. |
alexcrichton
commented
Aug 15, 2017
Ok I don't really know what config.sub is anyway but the commit message is at least clear enough to me of how to reproduce it! In that case let's... @bors: r+ |
bors
commented
Aug 15, 2017
📌 Commit 9d67d5a has been approved by |
ids1024
commented
Aug 15, 2017
TLDR: It's one of the weird and ugly things in autotools that seem awful, but does help with portability to various strange systems. This update seems to add fuchsia as well, so if they decide to implement Rust backtraces they won't run into that (small) issue. |
bors
commented
Aug 15, 2017
Make backtraces work on Redox, copying Unix implementation The `backtrace/` directory here is the same as the Unix one, except for adding an implementation of `get_executable_filename`.
bors
commented
Aug 15, 2017
☀️ Test successful - status-appveyor, status-travis |
The
backtrace/directory here is the same as the Unix one, except for adding an implementation ofget_executable_filename.