explicitly add SYSROOT/lib directory to dylib var

[semarie]

it makes platforms without (or partial) rpath support to be able to run
rustdoc binary.

[rust-highfive]

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

[semarie]

the build of nightly currently fail for OpenBSD.

please note I am unsure that src/bootstrap/bin/rustdoc.rs is the right place to correct the problem.

tracing it, I found that when rustdoc was called, the LD_LIBRARY_PATH coming empty. Explictly adding it in bootstrap-rustdoc binary makes it to work again.

[semarie]

@Mark-Simulacrum I saw you made some refactor regarding src/tools/rustdoc. Does this problem remind you something ? or do you know a better way to resolv it ?

[Mark-Simulacrum]

I think the right fix here is actually to make https://github.com/rust-lang/rust/blob/master/src/bootstrap/builder.rs#L430 be a call to rustc_libdir instead of sysroot_libdir, since that's what we do when invoking Cargo. Could you make that change instead, and see if it works on your platform? Thanks!

[Mark-Simulacrum]

Ah, I'll also reassign to review on me, though if I'm unresponsive, @alexcrichton is a good alternative.

[semarie]

@Mark-Simulacrum yes it works well with the proposed change. I updated the PR. Thanks.

[Mark-Simulacrum]

@bors r+

[bors]

📌 Commit c982d6a has been approved by Mark-Simulacrum

[bors]

⌛ Testing commit c982d6a with merge bcd75d6...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing bcd75d6 to master...