Skip to content

Make the driver API a little more useful for a tools shim - #43730

Merged
bors merged 2 commits into
rust-lang:masterfrom
nrc:driver-shim
Aug 10, 2017
Merged

Make the driver API a little more useful for a tools shim#43730
bors merged 2 commits into
rust-lang:masterfrom
nrc:driver-shim

Conversation

@nrc

@nrcnrc commented Aug 8, 2017

Copy link
Copy Markdown
Member

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@nrc

nrc commented Aug 8, 2017

Copy link
Copy Markdown
MemberAuthor

r? @eddyb

@rust-highfiverust-highfive assigned eddyb and unassigned arielb1Aug 8, 2017
@eddyb

eddyb commented Aug 8, 2017

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Aug 8, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 540a644 has been approved by eddyb

@arielb1

Copy link
Copy Markdown
Contributor
[00:31:18] Compiling rustdoc v0.0.0 (file:///checkout/src/librustdoc)
[00:31:23] error[E0061]: this function takes 3 parameters but 2 parameters were supplied
[00:31:23] --> /checkout/src/librustdoc/core.rs:158:55
[00:31:23] |
[00:31:23] 158 | let krate = panictry!(driver::phase_1_parse_input(&sess, &input));
[00:31:23] | ^^^^^^^^^^^^^ expected 3 parameters
[00:31:23] [00:31:25] error[E0061]: this function takes 3 parameters but 2 parameters were supplied
[00:31:25] --> /checkout/src/librustdoc/test.rs:94:55
[00:31:25] |
[00:31:25] 94 | let krate = panictry!(driver::phase_1_parse_input(&sess, &input));
[00:31:25] | ^^^^^^^^^^^^^ expected 3 parameters
[00:31:25] [00:31:25] error: aborting due to 2 previous errors

@bors r-

@arielb1arielb1 added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 8, 2017
@nrc

nrc commented Aug 9, 2017

Copy link
Copy Markdown
MemberAuthor

@bors: r=eddyb

@bors

bors commented Aug 9, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 8ba63a1 has been approved by eddyb

@nrcnrc added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 9, 2017
@bors

bors commented Aug 9, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 8ba63a1bc909d9f72f8d820a2c62b509cb12cdb3 with merge b0a47f7a9987e0285c3957c58ebb3eac62cf852f...

@bors

bors commented Aug 9, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@nrcnrc added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 9, 2017
@nrc

nrc commented Aug 9, 2017

Copy link
Copy Markdown
MemberAuthor

@bors: r=eddyb

@bors

bors commented Aug 9, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit a9a181d has been approved by eddyb

@nrcnrc added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 9, 2017
@bors

bors commented Aug 10, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit a9a181d with merge 57e720d...

bors added a commit that referenced this pull request Aug 10, 2017
Make the driver API a little more useful for a tools shim
Example use case: https://github.com/nrc/rls-rustc
@bors

bors commented Aug 10, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 57e720d to master...

@bors
bors merged commit a9a181d into rust-lang:masterAug 10, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@nrc@rust-highfive@eddyb@bors@arielb1