Uh oh!
There was an error while loading. Please reload this page.
rustdoc: Don't add external impls to implementors js - #43736
Merged
Conversation
rust-highfive
commented
Aug 8, 2017
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
Otherwise impls from not documented crates appear.
QuietMisdreavus
commented
Aug 12, 2017
Contributor
@bors r+ Thanks! This was a rabbit-hole i almost went down myself when working on something else. |
bors
commented
Aug 12, 2017
Collaborator
📌 Commit c62a8c5 has been approved by |
bors
commented
Aug 12, 2017
Collaborator
bors added a commit
that referenced
this pull request
Aug 12, 2017
rustdoc: Don't add external impls to implementors js Otherwise impls from not documented crates appear. Fixes#43701
bors
commented
Aug 13, 2017
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise impls from not documented crates appear.
Fixes#43701