Skip to content

rustdoc: Fix broken CSS in search results - #43760

Merged
bors merged 1 commit into
rust-lang:masterfrom
ollie27:rustdoc_search_css
Aug 11, 2017
Merged

rustdoc: Fix broken CSS in search results#43760
bors merged 1 commit into
rust-lang:masterfrom
ollie27:rustdoc_search_css

Conversation

@ollie27

Copy link
Copy Markdown
Contributor

The layout is currently broken for struct/union fields and enum variants
in the search results when searching from a struct, union or enum page.

Some examples:
https://doc.rust-lang.org/nightly/std/ops/struct.RangeInclusive.html?search=start
https://doc.rust-lang.org/nightly/std/option/enum.Option.html?search=some

#34477 was an incomplete fix

The layout is currently broken for struct/union fields and enum variants
in the search results when searching from a struct, union or enum page.
@rust-highfive

Copy link
Copy Markdown
Contributor

Some changes occurred in HTML/CSS.

cc @GuillaumeGomez

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @frewsxcv

(rust_highfive has picked a reviewer for you, use r? to override)

@aidanhsaidanhs added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 10, 2017
@GuillaumeGomez

Copy link
Copy Markdown
Member

Thanks!

@bors: r+

@bors

bors commented Aug 10, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit e5261c0 has been approved by GuillaumeGomez

@aidanhs

Copy link
Copy Markdown
Contributor

@bors rollup

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 11, 2017
…aumeGomez
rustdoc: Fix broken CSS in search results
The layout is currently broken for struct/union fields and enum variants
in the search results when searching from a struct, union or enum page.
Some examples:
https://doc.rust-lang.org/nightly/std/ops/struct.RangeInclusive.html?search=starthttps://doc.rust-lang.org/nightly/std/option/enum.Option.html?search=somerust-lang#34477 was an incomplete fix
bors added a commit that referenced this pull request Aug 11, 2017
MaloJaffre added a commit to MaloJaffre/rust that referenced this pull request Aug 11, 2017
…aumeGomez
rustdoc: Fix broken CSS in search results
The layout is currently broken for struct/union fields and enum variants
in the search results when searching from a struct, union or enum page.
Some examples:
https://doc.rust-lang.org/nightly/std/ops/struct.RangeInclusive.html?search=starthttps://doc.rust-lang.org/nightly/std/option/enum.Option.html?search=somerust-lang#34477 was an incomplete fix
@bors
bors merged commit e5261c0 into rust-lang:masterAug 11, 2017
@ollie27
ollie27 deleted the rustdoc_search_css branch August 11, 2017 12:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@ollie27@rust-highfive@GuillaumeGomez@bors@aidanhs@frewsxcv