Skip to content

Fix some typos - #43794

Merged
bors merged 2 commits into
rust-lang:masterfrom
Eijebong:fix_typos
Aug 12, 2017
Merged

Fix some typos#43794
bors merged 2 commits into
rust-lang:masterfrom
Eijebong:fix_typos

Conversation

@Eijebong

@EijebongEijebong commented Aug 10, 2017

Copy link
Copy Markdown
Contributor

I wrote a really naive script and found those typos in the documentation.

@rust-highfive

rust-highfive commented Aug 10, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

chordowl
chordowl reviewed Aug 10, 2017
View reviewed changes

@chordowlchordowl left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are quite amazing! ❤️

Comment threadsrc/libcore/num/dec2flt/algorithm.rs
}

/// Skip over most AlgorithmM iterations by checking the bit length.
/// Skip over most Algorithm M iterations by checking the bit length.

@chordowlchordowlAug 10, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be "algorithm", not "Algorithm M"

@EijebongEijebongAug 10, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another Algorithm M in the file, I assumed it was a name for an algorithm that was implemented in the file...

@steveklabniksteveklabnikAug 10, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after we sort this out

@EijebongEijebongAug 10, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I change both to algorithm then ?

@EijebongEijebongAug 10, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, I just looked it up, it's documenting a function called algorithm_m

@chordowlchordowlAug 10, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, my bad! Sorry!

@GuillaumeGomez

GuillaumeGomez commented Aug 11, 2017

Copy link
Copy Markdown
Member

@bors: r=lukaramu,steveklanik,imperio rollup

@bors

bors commented Aug 11, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit ea5be96 has been approved by lukaramu,steveklanik,imperio

MaloJaffre added a commit to MaloJaffre/rust that referenced this pull request Aug 11, 2017
@MaloJaffre
Rollup merge ofrust-lang#43794- Eijebong:fix_typos, r=lukaramu,stev…
84d6b0d
…eklanik,imperio
Fix some typos
I wrote a really naive script and found those typos in the documentation.
@MaloJaffreMaloJaffre mentioned this pull request Aug 11, 2017
Closed
@shepmastershepmaster added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 11, 2017
@EijebongEijebong mentioned this pull request Aug 11, 2017
Merged
@Manishearth

Manishearth commented Aug 11, 2017

Copy link
Copy Markdown
Member

@bors are you still there?

@bors

bors commented Aug 11, 2017

Copy link
Copy Markdown
Collaborator

🍰 Target acquired

@bors

bors commented Aug 12, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit ea5be96 with merge bffc973...

bors added a commit that referenced this pull request Aug 12, 2017
@bors
Auto merge of#43794- Eijebong:fix_typos, r=lukaramu,steveklanik,imp…
bffc973
…erio
Fix some typos
I wrote a really naive script and found those typos in the documentation.
@bors

bors commented Aug 12, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: lukaramu,steveklanik,imperio
Pushing bffc973 to master...

@bors
bors merged commit ea5be96 into rust-lang:masterAug 12, 2017
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 13, 2017
@GuillaumeGomez
Rollup merge ofrust-lang#43814- Eijebong:fix_typos2, r=petrochenkov
bc6659a
Fix some typos
Follow up of rust-lang#43794
If refined my script a little bit and found some more.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@steveklabniksteveklabniksteveklabnik approved these changes
@chordowlchordowlchordowl left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@nikomatsakisnikomatsakis

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Eijebong@rust-highfive@GuillaumeGomez@bors@Manishearth@steveklabnik@chordowl@nikomatsakis@shepmaster