Uh oh!
There was an error while loading. Please reload this page.
[beta] back out #42480 and its dependents - #43952
Merged
Merged
Conversation
arielb1
commented
Aug 17, 2017
ContributorAuthor
nikomatsakis
commented
Aug 17, 2017
Contributor
@bors r+ |
bors
commented
Aug 17, 2017
Collaborator
📌 Commit 97e9c7e has been approved by |
arielb1
commented
Aug 17, 2017
ContributorAuthor
This appears to fix all relevant issues. |
kennytm
commented
Aug 18, 2017
Member
@nikomatsakis@arielb1 The Homu queue doesn't register the r+, and it says "Mergeable = no". This may need a |
bors
commented
Aug 19, 2017
Collaborator
⌛ Testing commit 97e9c7e with merge 74d6f394826f597da41e376cb7b7de37e3935175... |
bors
commented
Aug 19, 2017
Collaborator
💔 Test failed - status-appveyor |
kennytm
commented
Aug 19, 2017
Member
bors
commented
Aug 19, 2017
Collaborator
bors
commented
Aug 19, 2017
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#42480 makes the ICE in #43132 worse, and the "safe" fix to that causes the #43787 exponential worst-case.
Let's back everything out for beta to avoid regressions, and get the permafix in nightly.