Remove duplicates in rustdoc

[GuillaumeGomez]

Fixes#43934.

Two things however:

1. I'm not happy with the current check. It seems completely overkill and unsatisfying.
2. I have no idea how to test if there is only one element and not two.

r? @rust-lang/docs

[ollie27]

This really needs to be done when inlining instead. We need to not inline things from globs if they are shadowed.

I have no idea how to test if there is only one element and not two.

You can use @count in rustdoc tests.

rust/src/etc/htmldocck.py

Lines 99 to 100 in 80be2f8

	* `@count PATH XPATH COUNT' checks for the occurrence of given XPath
	in the given file. The number of occurrences must match the given count.

[QuietMisdreavus]

I don't see how this else branch will return anything but None? Also was there any major reason that is_some needed the as_ref there?

[GuillaumeGomez]

To avoid a panic mainly. But I could directly return None, indeed.

[frewsxcv]

does something like items.get(*i).map(|n| full_path(cx, &items[*i])) work here?

nevermind, this is not equivalent

[GuillaumeGomez]

@ollie27: Nice, thanks!

[QuietMisdreavus]

[00:03:07] tidy error: /checkout/src/librustdoc/html/render.rs:1782: TODO is deprecated; use FIXME
[00:03:08] some tidy checks failed

(the rest of the travis run is stuck on mac builders)

[GuillaumeGomez]

Fixed the tidy issue (deprecating TODO is strange).

[QuietMisdreavus]

I'm willing to land this as-is. If we want to change how this deduplication happens later, we only need to take out one statement to revert this change. (Plus, we have a test for this now. :3)

@bors r+ rollup

[bors]

📌 Commit 5d71280 has been approved by QuietMisdreavus