Uh oh!
There was an error while loading. Please reload this page.
Mir borrowck as query - #44009
Conversation
rust-highfive
commented
Aug 21, 2017
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
We'll figure out the borrowck error story.
arielb1
commented
Aug 21, 2017
@bors r+ |
bors
commented
Aug 21, 2017
📌 Commit c9597ff has been approved by |
bors
commented
Aug 21, 2017
☔ The latest upstream changes (presumably #43986) made this pull request unmergeable. Please resolve the merge conflicts. |
(A followup commit removes the mir::transform based entry point.)
c9597ff to
d92c953Comparepnkfelix
commented
Aug 21, 2017
@bors r=arielb1 |
bors
commented
Aug 21, 2017
📌 Commit d92c953 has been approved by |
pnkfelix
commented
Aug 21, 2017
@bors cancel |
d92c953 to
224c6caComparepnkfelix
commented
Aug 21, 2017
@bors r=arielb1 |
bors
commented
Aug 21, 2017
📌 Commit 224c6ca has been approved by |
bors
commented
Aug 21, 2017
⌛ Testing commit 224c6ca with merge c326ad220ae5712937c8ee8085a074ebe1ff3fe0... |
bors
commented
Aug 21, 2017
💔 Test failed - status-travis |
kennytm
commented
Aug 21, 2017
@bors retry Build canceled without any reason. |
bors
commented
Aug 21, 2017
Mir borrowck as query Turn the `mir-borrowck` pass (aka "transform") into a query. (If I had realized how relatively easy this was going to be, I would have made it part of #43108. `let hindsight = 20/20;`)
bors
commented
Aug 21, 2017
☀️ Test successful - status-appveyor, status-travis |
Fix logic error in test guarding prototype MIR borrowck code. Fix logic error in test guarding prototype MIR borrowck code. tl;dr: 🤦 (This crept in during the shift from a transform to a query (#44009); I didn't notice because my muscle memory was still always passing `-Z mir-borrowck`, while my test cases *also* had the `#[rustc_mir_borrowck]` attribute attached to them.)
Turn the
mir-borrowckpass (aka "transform") into a query.(If I had realized how relatively easy this was going to be, I would have made it part of #43108.
let hindsight = 20/20;)