Skip to content

Remove Splice struct return value from String::splice - #44044

Merged
bors merged 1 commit into
rust-lang:masterfrom
mattico:string-splice-return
Aug 31, 2017
Merged

Remove Splice struct return value from String::splice#44044
bors merged 1 commit into
rust-lang:masterfrom
mattico:string-splice-return

Conversation

@mattico

@matticomattico commented Aug 22, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

The implementation is now almost identical to the one in the RFC.

Fixes#44038
cc #32310

@rust-highfive

rust-highfive commented Aug 22, 2017

Copy link
Copy Markdown
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@aidanhsaidanhs added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 23, 2017
@estebank

estebank commented Aug 26, 2017

Copy link
Copy Markdown
Contributor

@mattico It looks good to me. Could you squash the three commits?

@mattico
matticoforce-pushed the string-splice-return branch from 4450c93 to 0c3c43cCompareAugust 26, 2017 20:08
@dtolnaydtolnay assigned dtolnay and unassigned aturonAug 30, 2017
@dtolnay

dtolnay commented Aug 30, 2017

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Aug 30, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 0c3c43c has been approved by dtolnay

@bors

bors commented Aug 30, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 0c3c43c with merge 7b4bf09e37067540b325ee272f5819b8454006f4...

@bors

bors commented Aug 30, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@alexcrichton

alexcrichton commented Aug 30, 2017

Copy link
Copy Markdown
Member

@bors: retry

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Aug 30, 2017
@alexcrichton
Rollup merge ofrust-lang#44044- mattico:string-splice-return, r=dto…
581dc93
…lnay
Remove Splice struct return value from String::splice
The implementation is now almost identical to the one in the RFC.
Fixesrust-lang#44038
cc rust-lang#32310
@alexcrichtonalexcrichton mentioned this pull request Aug 30, 2017
Merged
bors added a commit that referenced this pull request Aug 31, 2017
@bors
Auto merge of#44186- alexcrichton:rollup, r=alexcrichton
890c87b
Rollup of 8 pull requests
- Successful merges: #44044, #44089, #44116, #44125, #44154, #44157, #44160, #44172
- Failed merges: #44162
@bors
bors merged commit 0c3c43c into rust-lang:masterAug 31, 2017
@mattico
mattico deleted the string-splice-return branch August 31, 2017 17:31
@dtolnaydtolnay mentioned this pull request Sep 17, 2017
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@dtolnaydtolnay

Labels

S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@mattico@rust-highfive@estebank@dtolnay@bors@alexcrichton@aturon@aidanhs