Uh oh!
There was an error while loading. Please reload this page.
[beta] Track closure signatures & kinds in freshened types - #44148
Merged
Conversation
This allows caching closure signatures and kinds in the normal selection and evaluation caches, and fixes the exponential worst-case in @remram44's example, which is a part of rust-lang#43787. This improvement is complenentary to rust-lang#43999 - they fix different cases.
arielb1
commented
Aug 29, 2017
ContributorAuthor
rust-highfive
commented
Aug 29, 2017
Contributor
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
commented
Aug 29, 2017
Contributor
|
nikomatsakis
commented
Aug 29, 2017
Contributor
@bors r+ |
bors
commented
Aug 29, 2017
Collaborator
📌 Commit b2a4661 has been approved by |
remram44
commented
Aug 29, 2017
Contributor
I tested this PR and can confirm that it fixes the compilation time on my particular example. Thanks! |
bors
commented
Aug 31, 2017
Collaborator
bors added a commit
that referenced
this pull request
Aug 31, 2017
[beta] Track closure signatures & kinds in freshened types This allows caching closure signatures and kinds in the normal selection and evaluation caches, and fixes the exponential worst-case in @remram44's example, which is a part of #43787. This improvement is complenentary to #43999 - they fix different cases. This is the pre-generators variation of #43938, cloned for beta.
bors
commented
Aug 31, 2017
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows caching closure signatures and kinds in the normal selection
and evaluation caches, and fixes the exponential worst-case in
@remram44's example, which is a part of #43787.
This improvement is complenentary to #43999 - they fix different cases.
This is the pre-generators variation of #43938, cloned for beta.