Uh oh!
There was an error while loading. Please reload this page.
rustbuild: Remove invalid doctest from bootstrap.py - #44268
Conversation
Mark-Simulacrum
commented
Sep 2, 2017
@bors r+ -- I think I recently saw this fail on Travis, too, but the overall build didn't fail. Did you see the doctests failing locally and stopping the build in the entirety? |
bors
commented
Sep 2, 2017
📌 Commit 5499d2b has been approved by |
kennytm
commented
Sep 2, 2017
@Mark-Simulacrum I just find it annoying that the failing test appear before The strange thing is that even if the test failed, the return code is still 0 (success), so while it should stop the build, it doesn't. Also, I expect the content should be collapsed between |
5499d2b to
13df0e9CompareMake sure that if the test is failed, the CI will stop the build.
13df0e9 to
4d06185Comparekennytm
commented
Sep 2, 2017
@Mark-Simulacrum OK now the |
Mark-Simulacrum
commented
Sep 2, 2017
Thanks! @bors r+ |
bors
commented
Sep 2, 2017
📌 Commit 4d06185 has been approved by |
kennytm
commented
Sep 2, 2017
@bors rollup (pretty sure it won't interfere other Rust code) |
bors
commented
Sep 4, 2017
…lacrum rustbuild: Remove invalid doctest from bootstrap.py
bors
commented
Sep 4, 2017
☀️ Test successful - status-appveyor, status-travis |
No description provided.