Skip to content

documentation update to demonstrate mutability - #44467

Merged
bors merged 1 commit into
rust-lang:masterfrom
toidiu:ak-44382
Sep 10, 2017
Merged

documentation update to demonstrate mutability#44467
bors merged 1 commit into
rust-lang:masterfrom
toidiu:ak-44382

Conversation

@toidiu

@toidiutoidiu commented Sep 9, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

#44467

  • demonstrate correct implementation returns Some
  • demonstrate out of bounds returns None
  • demonstrate mutability

@rust-highfive

rust-highfive commented Sep 9, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@toidiu

toidiu commented Sep 9, 2017•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

r? @frewsxcv

frewsxcv
frewsxcv approved these changes Sep 9, 2017
View reviewed changes

@frewsxcvfrewsxcv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! will wait for travis before approving for merge. thanks!

Comment threadsrc/liballoc/str.rs
/// assert_eq!("hello", v);
/// {
/// let s = v.get_mut(0..2);
/// let s = s.map(|s| {

@frewsxcvfrewsxcvSep 9, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alternatively, something like this could maybe work here, but what you have is 🆒 too

ifletSome(s) = v.get_mut(0..2){
s.make_ascii_uppercase();}

@frewsxcv

frewsxcv commented Sep 10, 2017

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Sep 10, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit c430fa8 has been approved by frewsxcv

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 10, 2017
@GuillaumeGomez
Rollup merge ofrust-lang#44467- toidiu:ak-44382, r=frewsxcv
8a7d93b
documentation update to demonstrate mutability
rust-lang#44467
- demonstrate correct implementation returns `Some`
- demonstrate out of bounds returns `None`
- demonstrate mutability
@GuillaumeGomezGuillaumeGomez mentioned this pull request Sep 10, 2017
Merged
bors added a commit that referenced this pull request Sep 10, 2017
@bors
Auto merge of#44474- GuillaumeGomez:rollup, r=GuillaumeGomez
d290dec
Rollup of 13 pull requests
- Successful merges: #44262, #44329, #44332, #44347, #44372, #44384, #44387, #44396, #44449, #44451, #44457, #44464, #44467
- Failed merges:
@bors
bors merged commit c430fa8 into rust-lang:masterSep 10, 2017
@frewsxcvfrewsxcv mentioned this pull request Sep 10, 2017
Closed
@toidiu
toidiu deleted the ak-44382 branch September 29, 2017 04:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@frewsxcvfrewsxcvfrewsxcv approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@aturonaturon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@toidiu@rust-highfive@frewsxcv@bors@aturon