Uh oh!
There was an error while loading. Please reload this page.
rustc: Forbid interpolated tokens in the HIR - #44601
Merged
Merged
Conversation
rust-highfive
commented
Sep 15, 2017
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
commented
Sep 15, 2017
MemberAuthor
r? @nrc cc @jseyfried |
michaelwoerister
commented
Sep 15, 2017
Member
Looks great! @jseyfried or @nrc, would you care to review this? |
nrc
commented
Sep 16, 2017
Member
@bors: r+ |
bors
commented
Sep 16, 2017
Collaborator
📌 Commit d3205f1 has been approved by |
TimNN
commented
Sep 17, 2017
Contributor
@bors r-
|
alexcrichtonforce-pushed
the
lower-attributes-in-hir
branch
from
September 17, 2017 17:44
d3205f1 to
52184d6Comparealexcrichton
commented
Sep 17, 2017
MemberAuthor
@bors: r=nrc |
bors
commented
Sep 17, 2017
Collaborator
📌 Commit 52184d6 has been approved by |
bors
commented
Sep 18, 2017
Collaborator
⌛ Testing commit 52184d6e609cba80e744117dd43c1b1b41eec93f with merge 53c2fd1ca517668767caeee79127c32d39a9e496... |
bors
commented
Sep 18, 2017
Collaborator
💔 Test failed - status-appveyor |
kennytm
commented
Sep 18, 2017
Member
Details |
bors
commented
Sep 18, 2017
Collaborator
☔ The latest upstream changes (presumably #44678) made this pull request unmergeable. Please resolve the merge conflicts. |
Right now the HIR contains raw `syntax::ast::Attribute` structure but nowadays
these can contain arbitrary tokens. One variant of the `Token` enum is an
"interpolated" token which basically means to shove all the tokens for a
nonterminal in this position. A "nonterminal" in this case is roughly analagous
to a macro argument:
macro_rules! foo {
($a:expr) => {
// $a is a nonterminal as an expression
}
}
Currently nonterminals contain namely items and expressions, and this poses a
problem for incremental compilation! With incremental we want a stable hash of
all HIR items, but this means we may transitively need a stable hash *of the
entire AST*, which is certainly not stable w/ node ids and whatnot. Hence today
there's a "bug" where the "stable hash" of an AST is just the raw hash value of
the AST, and this only arises with interpolated nonterminals. The downside of
this approach, however, is that a bunch of errors get spewed out during
compilation about how this isn't a great idea.
This PR is focused at fixing these warnings, basically deleting them from the
compiler. The implementation here is to alter attributes as they're lowered from
the AST to HIR, expanding all nonterminals in-place as we see them. This code
for expanding a nonterminal to a token stream already exists for the
`proc_macro` crate, so we basically just reuse the same implementation there.
After this PR it's considered a bug to have an `Interpolated` token and hence
the stable hash implementation simply uses `bug!` in this location.
Closesrust-lang#40946alexcrichtonforce-pushed
the
lower-attributes-in-hir
branch
from
September 19, 2017 00:20
52184d6 to
0694e4fComparealexcrichton
commented
Sep 19, 2017
MemberAuthor
@bors: r=nrc |
bors
commented
Sep 19, 2017
Collaborator
📌 Commit 0694e4f has been approved by |
bors
commented
Sep 19, 2017
Collaborator
bors added a commit
that referenced
this pull request
Sep 19, 2017
rustc: Forbid interpolated tokens in the HIR
Right now the HIR contains raw `syntax::ast::Attribute` structure but nowadays
these can contain arbitrary tokens. One variant of the `Token` enum is an
"interpolated" token which basically means to shove all the tokens for a
nonterminal in this position. A "nonterminal" in this case is roughly analagous
to a macro argument:
macro_rules! foo {
($a:expr) => {
// $a is a nonterminal as an expression
}
}
Currently nonterminals contain namely items and expressions, and this poses a
problem for incremental compilation! With incremental we want a stable hash of
all HIR items, but this means we may transitively need a stable hash *of the
entire AST*, which is certainly not stable w/ node ids and whatnot. Hence today
there's a "bug" where the "stable hash" of an AST is just the raw hash value of
the AST, and this only arises with interpolated nonterminals. The downside of
this approach, however, is that a bunch of errors get spewed out during
compilation about how this isn't a great idea.
This PR is focused at fixing these warnings, basically deleting them from the
compiler. The implementation here is to alter attributes as they're lowered from
the AST to HIR, expanding all nonterminals in-place as we see them. This code
for expanding a nonterminal to a token stream already exists for the
`proc_macro` crate, so we basically just reuse the same implementation there.
After this PR it's considered a bug to have an `Interpolated` token and hence
the stable hash implementation simply uses `bug!` in this location.
Closes#40946bors
commented
Sep 19, 2017
Collaborator
☀️ Test successful - status-appveyor, status-travis |
Manishearth
commented
Sep 21, 2017
Member
This may have caused a regression wrt doc attributes |
alexcrichton added a commit
to alexcrichton/rust
that referenced
this pull request
Sep 21, 2017
This commit fixes a regression from rust-lang#44601 where lowering attribute to HIR now involves expanding interpolated tokens to their actual tokens. In that commit all interpolated tokens were surrounded with a `DelimToken::None` group of tokens, but this ended up causing regressions like rust-lang#44730 where the various attribute parsers in `syntax/attr.rs` weren't ready to cope with `DelimToken::None`. Instead of fixing the parser in `attr.rs` this commit instead opts to just avoid the `DelimToken::None` in the first place, ensuring that the token stream should look the same as it did before where possible. Closesrust-lang#44730
frewsxcv added a commit
to frewsxcv/rust
that referenced
this pull request
Sep 23, 2017
rustc: Don't use DelimToken::None if possible This commit fixes a regression from rust-lang#44601 where lowering attribute to HIR now involves expanding interpolated tokens to their actual tokens. In that commit all interpolated tokens were surrounded with a `DelimToken::None` group of tokens, but this ended up causing regressions like rust-lang#44730 where the various attribute parsers in `syntax/attr.rs` weren't ready to cope with `DelimToken::None`. Instead of fixing the parser in `attr.rs` this commit instead opts to just avoid the `DelimToken::None` in the first place, ensuring that the token stream should look the same as it did before where possible. Closesrust-lang#44730
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now the HIR contains raw
syntax::ast::Attributestructure but nowadaysthese can contain arbitrary tokens. One variant of the
Tokenenum is an"interpolated" token which basically means to shove all the tokens for a
nonterminal in this position. A "nonterminal" in this case is roughly analagous
to a macro argument:
Currently nonterminals contain namely items and expressions, and this poses a
problem for incremental compilation! With incremental we want a stable hash of
all HIR items, but this means we may transitively need a stable hash of the
entire AST, which is certainly not stable w/ node ids and whatnot. Hence today
there's a "bug" where the "stable hash" of an AST is just the raw hash value of
the AST, and this only arises with interpolated nonterminals. The downside of
this approach, however, is that a bunch of errors get spewed out during
compilation about how this isn't a great idea.
This PR is focused at fixing these warnings, basically deleting them from the
compiler. The implementation here is to alter attributes as they're lowered from
the AST to HIR, expanding all nonterminals in-place as we see them. This code
for expanding a nonterminal to a token stream already exists for the
proc_macrocrate, so we basically just reuse the same implementation there.After this PR it's considered a bug to have an
Interpolatedtoken and hencethe stable hash implementation simply uses
bug!in this location.Closes#40946