Uh oh!
There was an error while loading. Please reload this page.
improvements to option module - #4465
Merged
Merged
Conversation
catamorphism added a commit
that referenced
this pull request
Jan 13, 2013
improvements to option module
catamorphism
commented
Jan 13, 2013
Contributor
Thanks! |
RalfJung added a commit
to RalfJung/rust
that referenced
this pull request
Jul 16, 2025
readme: update strict provenance link
Muscraft pushed a commit
to Muscraft/rust
that referenced
this pull request
Jul 21, 2025
readme: update strict provenance link
U007D pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
4497: Create LowerCtx on the fly r=matklad a=edwin0cheng Previously we create `LowerCtx` at the beginning of lowering, however, the hygiene content is in fact changing between macro expression expanding. This PR change it to create the `LowerCtx` on the fly to fix above bug. However, rust-lang#4465 is not fixed by this PR, the goto-def is still not work yet. It only fixed the infer part. Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't add an equivalent free function for
map_consume_default,mutateandmutate_defaultbecause as far as I can tell the only purpose of the free function versions is backwards compatibility.The
mutatemethods are based on a need I have in my balanced tree implementation, which arises from doing it entirely withoutCopy/Clone. It factors out variations of the following pattern which occurs many times: