Uh oh!
There was an error while loading. Please reload this page.
std::bigint: improve performance - #4470
Conversation
catamorphism
commented
Jan 13, 2013
I would appreciate more comments in the Thanks! |
lomereiter
commented
Jan 14, 2013
Could you add figures for the GMP bindings available via |
brson
commented
Feb 4, 2013
I agree this is a lot of tricky, uncommented code. Most people (like me) are not intimately familiar with bignum math and will not immediately understand what is going on here. @gifnksm can you document this code a little more? I don't even know what documentation it needs because I don't understand it. |
catamorphism
commented
Feb 15, 2013
I'm going to close this pull request and ask that @gifnksm submit a new one with comments if you're able to get around to it. Performance improvements are great, but they need to be documented. |
pnkfelix
commented
Oct 1, 2013
cc me. (i looked briefly at the bigint code we have now and may want to resurrect this patch, or at least review it before embarking on trying to improve our current bigint code.) |
allow using different cargo binary
allow using different cargo binary
4470: Handle `Self` in values and patterns r=matklad a=flodiebold I.e. - `Self(x)` or `Self` in tuple/unit struct impls - `Self::Variant(x)` or `Self::Variant` in enum impls - the same in patterns Fixesrust-lang#4454. Co-authored-by: Florian Diebold <florian.diebold@freiheit.com>
This commit reduces extra memory allocation in std::bigint.
In my simple benchmark test, time of computing
1000!becomes ~1000x faster.There still may be some points to be improved in performance. For example, switching the algorithms depending on the length of the array.