Uh oh!
There was an error while loading. Please reload this page.
Overlapping borrows can point to different lvalues. - #44999
Merged
bors merged 1 commit intoOct 4, 2017
Conversation
There's always a basis for the overlap, so instead of removing the assert entirely, I instead pass in the prefix that we found and check that it actually is a prefix of both lvalues. Fixrust-lang#44829
rust-highfive
commented
Oct 3, 2017
Contributor
(rust_highfive has picked a reviewer for you, use r? to override) |
pnkfelix
commented
Oct 3, 2017
ContributorAuthor
fyi this is going to collide with the merge of #44882; its easy to deal with and I'll update the PR after that lands. |
nikomatsakis
approved these changes
Oct 3, 2017
nikomatsakis
commented
Oct 3, 2017
Contributor
@bors r+ |
bors
commented
Oct 3, 2017
Collaborator
📌 Commit aac64c4 has been approved by |
bors
commented
Oct 4, 2017
Collaborator
bors added a commit
that referenced
this pull request
Oct 4, 2017
…=nikomatsakis Overlapping borrows can point to different lvalues. Overlapping borrows can point to different lvalues. There's always a basis for the overlap, so instead of removing the assert entirely, I instead pass in the prefix that we found and check that it actually is a prefix of both lvalues. Fix#44829
bors
commented
Oct 4, 2017
Collaborator
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overlapping borrows can point to different lvalues.
There's always a basis for the overlap, so instead of removing the assert entirely, I instead pass in the prefix that we found and check that it actually is a prefix of both lvalues.
Fix#44829