Uh oh!
There was an error while loading. Please reload this page.
debuginfo-test: Fix #45086. - #45091
Merged
Merged
Conversation
LLDB's output may be None instead of '', and that will cause type mismatch when normalize_whitespace() expects a string instead of None. This commit simply ensures we do pass '' even if the output is None.
rust-highfive
commented
Oct 7, 2017
Contributor
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
k0pernicus
commented
Oct 7, 2017
Contributor
Thank you for this PR @kennytm - got this problem yesterday actually. |
michaelwoerister
commented
Oct 9, 2017
Member
bors
commented
Oct 9, 2017
Collaborator
📌 Commit 07b1899 has been approved by |
michaelwoerister
commented
Oct 9, 2017
Member
@bors rollup |
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Oct 9, 2017
debuginfo-test: Fixrust-lang#45086. Fixesrust-lang#45086, where all debuginfo-lldb fails when using LLDB from Xcode 9.
bors added a commit
that referenced
this pull request
Oct 10, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#45086, where all debuginfo-lldb fails when using LLDB from Xcode 9.