Skip to content

Documented a few more unstable feature gates. - #45166

Merged
bors merged 4 commits into
rust-lang:masterfrom
tinaun:more_unstable_docs
Oct 13, 2017
Merged

Documented a few more unstable feature gates.#45166
bors merged 4 commits into
rust-lang:masterfrom
tinaun:more_unstable_docs

Conversation

@tinaun

@tinauntinaun commented Oct 10, 2017

Copy link
Copy Markdown
Contributor

unboxed closures, fn_traits, and OIBIT. hope these are decent!

@rust-highfive

rust-highfive commented Oct 10, 2017

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik

steveklabnik commented Oct 10, 2017

Copy link
Copy Markdown
Contributor
[01:16:00] unstable-book/print.html:2083: broken link - unstable-book/library-features/fn-traits.md
[01:16:00] unstable-book/print.html:2546: broken link - unstable-book/language-features/unboxed-closures.md
[01:16:00] unstable-book/library-features/fn-traits.html:93: broken link - unstable-book/language-features/unboxed-closures.md
[01:16:00] unstable-book/language-features/unboxed-closures.html:93: broken link - unstable-book/library-features/fn-traits.md

r=me after the links get fixed. thank you!

@tinaun

tinaun commented Oct 10, 2017

Copy link
Copy Markdown
ContributorAuthor

r= @steveklabnik

@kennytm

kennytm commented Oct 11, 2017

Copy link
Copy Markdown
Member

@bors r=steveklabnik rollup

@bors

bors commented Oct 11, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit d5ef9f9 has been approved by steveklabnik

@bors

bors commented Oct 11, 2017

Copy link
Copy Markdown
Collaborator

🌲 The tree is currently closed for pull requests below priority 2, this pull request will be tested once the tree is reopened

@kennytmkennytm mentioned this pull request Oct 11, 2017
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Oct 11, 2017
@kennytm
Rollup merge ofrust-lang#45166- tinaun:more_unstable_docs, r=stevek…
1faf129
…labnik
Documented a few more unstable feature gates.
unboxed closures, fn_traits, and OIBIT. hope these are decent!
@kennytmkennytm mentioned this pull request Oct 11, 2017
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Oct 12, 2017
@kennytm
Rollup merge ofrust-lang#45166- tinaun:more_unstable_docs, r=stevek…
5d25e1e
…labnik
Documented a few more unstable feature gates.
unboxed closures, fn_traits, and OIBIT. hope these are decent!
@kennytmkennytm mentioned this pull request Oct 12, 2017
Merged
@aidanhsaidanhs added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 12, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Oct 12, 2017
@kennytm
Rollup merge ofrust-lang#45166- tinaun:more_unstable_docs, r=stevek…
7640cda
…labnik
Documented a few more unstable feature gates.
unboxed closures, fn_traits, and OIBIT. hope these are decent!
bors added a commit that referenced this pull request Oct 12, 2017
@bors
Auto merge of#45233- kennytm:rollup, r=<try>
6f8b325
[WIP] Rollup of 10 pull requests
- Successful merges: #44989, #45005, #45049, #45105, #45121, #45163, #45166, #45172, #45190, #45231
- Failed merges: #45138
bors added a commit that referenced this pull request Oct 12, 2017
@bors
Auto merge of#45233- kennytm:rollup, r=kennytm
64ee7d1
Rollup of 9 pull requests
- Successful merges: #44989, #45005, #45049, #45105, #45121, #45166, #45172, #45190, #45231
- Failed merges: #45138
@bors
bors merged commit d5ef9f9 into rust-lang:masterOct 13, 2017
@tinaun
tinaun deleted the more_unstable_docs branch January 23, 2018 07:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@steveklabniksteveklabniksteveklabnik approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@GuillaumeGomezGuillaumeGomez

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tinaun@rust-highfive@steveklabnik@kennytm@bors@aidanhs@GuillaumeGomez