Skip to content

Add suggestions for misspelled labels - #45173

Merged
bors merged 1 commit into
rust-lang:masterfrom
laumann:suggest-misspelled-labels
Oct 13, 2017
Merged

Add suggestions for misspelled labels#45173
bors merged 1 commit into
rust-lang:masterfrom
laumann:suggest-misspelled-labels

Conversation

@laumann

@laumannlaumann commented Oct 10, 2017

Copy link
Copy Markdown

Another part of #30197

@rust-highfive

rust-highfive commented Oct 10, 2017

Copy link
Copy Markdown
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

petrochenkov
petrochenkov reviewed Oct 10, 2017
View reviewed changes
Comment threadsrc/librustc_resolve/lib.rs Outdated

@petrochenkovpetrochenkovOct 10, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you replace the default label with Levenshtein-based message instead to avoid multiple messages?

if some lev_candidate {
span_label("did you mean...")
} else {
span_label("undeclared label")
}

@laumannlaumannOct 10, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

@petrochenkov

petrochenkov commented Oct 10, 2017

Copy link
Copy Markdown
Contributor

LGTM modulo #45173 (comment)

@petrochenkov

petrochenkov commented Oct 10, 2017

Copy link
Copy Markdown
Contributor

@bors r+
Thanks!

@bors

bors commented Oct 10, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 843dc60 has been approved by petrochenkov

@bors

bors commented Oct 11, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 843dc60 with merge 2cedc4b58db20d3715cbfe40bed1d05b8de30c86...

@bors

bors commented Oct 11, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@kennytm

kennytm commented Oct 11, 2017

Copy link
Copy Markdown
Member

@bors retry

@laumann

laumann commented Oct 11, 2017

Copy link
Copy Markdown
Author

Is there something I need to do here?

@kennytm

kennytm commented Oct 11, 2017

Copy link
Copy Markdown
Member

@laumann Nope.

There was an incident several hours ago causing the CI to reject every PR. Now that it is fixed, all approved PR are re-queued. Currently this is at the 19th place in the queue, so expect to wait about 2 days before this actually get tested.

@laumann

laumann commented Oct 11, 2017

Copy link
Copy Markdown
Author

@kennytm Oh, ok, thanks for the explanation :-)

@aidanhsaidanhs added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 12, 2017
@Mark-Simulacrum

Mark-Simulacrum commented Oct 13, 2017

Copy link
Copy Markdown
Member

@bors rollup

kennytm added a commit to kennytm/rust that referenced this pull request Oct 13, 2017
@kennytm
Rollup merge ofrust-lang#45173- laumann:suggest-misspelled-labels, …
46d86d3
…r=petrochenkov
Add suggestions for misspelled labels
Another part of rust-lang#30197
@kennytmkennytm mentioned this pull request Oct 13, 2017
Merged
bors added a commit that referenced this pull request Oct 13, 2017
@bors
Auto merge of#45261- kennytm:rollup, r=kennytm
6cb49d2
Rollup of 14 pull requests
- Successful merges: #44855, #45110, #45122, #45133, #45173, #45178, #45189, #45203, #45209, #45221, #45236, #45240, #45245, #45253
- Failed merges:
@bors
bors merged commit 843dc60 into rust-lang:masterOct 13, 2017
@laumann
laumann deleted the suggest-misspelled-labels branch October 16, 2017 07:03
@petrochenkovpetrochenkov mentioned this pull request Dec 25, 2018
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkovpetrochenkovpetrochenkov left review comments

Assignees

@petrochenkovpetrochenkov

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@laumann@rust-highfive@petrochenkov@bors@kennytm@Mark-Simulacrum@eddyb@aidanhs