Skip to content

Save the highlighted item when switching tab - #45288

Merged
bors merged 2 commits into
rust-lang:masterfrom
GuillaumeGomez:tab-key-binding
Oct 20, 2017
Merged

Save the highlighted item when switching tab#45288
bors merged 2 commits into
rust-lang:masterfrom
GuillaumeGomez:tab-key-binding

Conversation

@GuillaumeGomez

@GuillaumeGomezGuillaumeGomez commented Oct 14, 2017•
edited
Loading

Copy link
Copy Markdown
Member

To be merged after #45281.

r? @rust-lang/docs

@rust-highfive

rust-highfive commented Oct 14, 2017

Copy link
Copy Markdown
Contributor

Some changes occurred in HTML/CSS.

cc @GuillaumeGomez

@rust-highfive

rust-highfive commented Oct 14, 2017

Copy link
Copy Markdown
Contributor

r? @QuietMisdreavus

(rust_highfive has picked a reviewer for you, use r? to override)

@kennytmkennytm added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 14, 2017
@dns2utf8dns2utf8 mentioned this pull request Oct 14, 2017
Closed
dns2utf8
dns2utf8 reviewed Oct 14, 2017
View reviewed changes
Comment threadsrc/librustdoc/html/static/main.js Outdated

@dns2utf8dns2utf8Oct 14, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this current store? Is it the same as the currentTab from the outer scope?

@GuillaumeGomezGuillaumeGomezOct 14, 2017•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's a local one when we're iterating over tabs. I'll update the variable's name.

dns2utf8
dns2utf8 reviewed Oct 14, 2017
View reviewed changes
Comment threadsrc/librustdoc/html/static/main.js Outdated

@dns2utf8dns2utf8Oct 14, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that line still required?

@GuillaumeGomezGuillaumeGomezOct 14, 2017

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. Removing it. Thanks for spotting it!

dns2utf8
dns2utf8 approved these changes Oct 15, 2017
View reviewed changes

@dns2utf8dns2utf8 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you 👍

@kennytmkennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 15, 2017
@QuietMisdreavus

QuietMisdreavus commented Oct 17, 2017

Copy link
Copy Markdown
Contributor

Looks good! r=me when #45281 hits. This seems to be a superset of that PR, so hopefully it won't make a merge conflict.

@GuillaumeGomez

GuillaumeGomez commented Oct 19, 2017

Copy link
Copy Markdown
MemberAuthor

@bors: r=QuietMisdreavus

@bors

bors commented Oct 19, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit f442326 has been approved by QuietMisdreavus

@bors

bors commented Oct 19, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit f442326 with merge a651106...

bors added a commit that referenced this pull request Oct 19, 2017
@bors
Auto merge of#45288- GuillaumeGomez:tab-key-binding, r=QuietMisdreavus
a651106
Save the highlighted item when switching tab
To be merged after #45281.
r? @rust-lang/docs
@bors

bors commented Oct 20, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: QuietMisdreavus
Pushing a651106 to master...

@bors
bors merged commit f442326 into rust-lang:masterOct 20, 2017
@GuillaumeGomez
GuillaumeGomez deleted the tab-key-binding branch October 20, 2017 08:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@dns2utf8dns2utf8dns2utf8 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@QuietMisdreavusQuietMisdreavus

Labels

S-waiting-on-reviewStatus: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@GuillaumeGomez@rust-highfive@QuietMisdreavus@bors@dns2utf8@kennytm