Uh oh!
There was an error while loading. Please reload this page.
Bump the minimum LLVM to 3.9 - #45326
Merged
Merged
Conversation
Old LLVM bugs are reportedly cropping up harder, but 3.9 seems to be OK. Fixesrust-lang#45277.
The necessary changes were only in upstream LLVM in 4.0, but they were for a while backported to Rust LLVM. Now that Rust LLVM is also 4.0, we can make the test conditional here more accurate.
While the `config.toml.example` comments say "we automatically check the version by default," we actually didn't. That check was badly out of date, only allowing 3.5, 3.6, or 3.7. This it now updated to the new 3.9 minimum requirement, and truly enabled by default.
cuviper
commented
Oct 16, 2017
MemberAuthor
alexcrichton
commented
Oct 17, 2017
Member
@bors: r+ |
bors
commented
Oct 17, 2017
Collaborator
📌 Commit 6f33108 has been approved by |
eddyb
commented
Oct 18, 2017
Contributor
@bors r- You should also remove |
cuviper
commented
Oct 18, 2017
MemberAuthor
@eddyb -- I removed that and one for 3.8. |
alexcrichton
commented
Oct 18, 2017
Member
@bors: r+ |
bors
commented
Oct 18, 2017
Collaborator
📌 Commit 6309a47 has been approved by |
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Oct 18, 2017
Bump the minimum LLVM to 3.9 Old LLVM bugs are reportedly cropping up harder, but 3.9 seems to be OK. Fixesrust-lang#45277.
cuviper added a commit
to cuviper/rust
that referenced
this pull request
Dec 1, 2017
We bumped the minimum LLVM to 3.9 in rust-lang#45326. This just cleans up the conditional code in the rustllvm C++ wrappers to assume at least 3.9.
bors added a commit
that referenced
this pull request
Dec 3, 2017
Assume at least LLVM 3.9 in rustllvm and rustc_llvm We bumped the minimum LLVM to 3.9 in #45326. This just cleans up the conditional code in the `rustllvm` C++ wrappers to assume that minimum, and similarly cleans up the `rustc_llvm` build script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old LLVM bugs are reportedly cropping up harder, but 3.9 seems to be OK.
Fixes#45277.