rustc: Add `_imp_` symbols later in compilation by alexcrichton · Pull Request #45348 · rust-lang/rust

alexcrichton · 2017-10-18T00:33:23Z

On MSVC targets rustc will add symbols prefixed with _imp_ to LLVM modules to
"emulate" dllexported statics as that workaround is still in place after #27438
hasn't been solved otherwise. These statics, however, were getting gc'd by
ThinLTO accidentally which later would cause linking failures.

This commit updates the location we add such symbols to happen just before
codegen to ensure that (a) they're not eliminated by the optimizer and (b) the
optimizer doesn't even worry about them.

Closes#45347

rust-highfive · 2017-10-18T00:33:27Z

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

alexcrichton · 2017-10-18T00:33:31Z

r? @michaelwoerister

michaelwoerister

Thanks, @alexcrichton!

r=me with the comment in the test case added.

michaelwoerister · 2017-10-18T09:29:06Z

Could you add a comment what this is all about? Otherwise one might be a little lost when this test fails.

On MSVC targets rustc will add symbols prefixed with `_imp_` to LLVM modules to "emulate" dllexported statics as that workaround is still in place after rust-lang#27438 hasn't been solved otherwise. These statics, however, were getting gc'd by ThinLTO accidentally which later would cause linking failures. This commit updates the location we add such symbols to happen just before codegen to ensure that (a) they're not eliminated by the optimizer and (b) the optimizer doesn't even worry about them. Closesrust-lang#45347

alexcrichton · 2017-10-18T14:01:40Z

@bors: r=michaelwoerister

bors · 2017-10-18T14:01:41Z

📌 Commit 3541ffb has been approved by michaelwoerister

bors · 2017-10-20T13:24:31Z

⌛ Testing commit 3541ffb with merge 0e612b6c44ca77fa77c60680ebf0f8a498902dee...

bors · 2017-10-20T14:33:39Z

💔 Test failed - status-appveyor

kennytm · 2017-10-20T14:39:01Z

The test against xsv failed on check-aux x86_64-pc-windows-msvc

Details

[01:08:09] failures:
[01:08:09] [01:08:09] ---- test_frequency::prop_frequency stdout ----
[01:08:09] [C:\projects\rust\build\ct\xsv\target\debug\xit\prop_frequency\test-821]: "C:\\projects\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "frequency" "in.csv" "-j" "4" "--limit" "0"
[01:08:09] [C:\projects\rust\build\ct\xsv\target\debug\xit\prop_frequency\test-823]: "C:\\projects\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "frequency" "in.csv" "-j" "4" "--limit" "0"
...
[01:08:09] [C:\projects\rust\build\ct\xsv\target\debug\xit\prop_frequency\test-957]: "C:\\projects\\rust\\build\\ct\\xsv\\target\\debug\\xsv" "frequency" "in.csv" "-j" "4" "--limit" "0"
[01:08:09] thread 'test_frequency::prop_frequency' panicked at '[quickcheck] TEST FAILED (runtime error). Arguments: (CsvData { data: [[[239, 187, 191]], [[]]] })
[01:08:09] Error: "called `Option::unwrap()` on a `None` value"', C:\Users\appveyor\.cargo\registry\src\github.com-1ecc6299db9ec823\quickcheck-0.4.1\src\tester.rs:147:27
[01:08:09] [01:08:09] [01:08:09] failures:
[01:08:09] test_frequency::prop_frequency
[01:08:09] [01:08:09] test result: FAILED. 420 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
[01:08:09] [01:08:09] error: test failed, to rerun pass '--test tests'

alexcrichton · 2017-10-20T14:51:08Z

wut

alexcrichton · 2017-10-20T16:28:42Z

That test failure is a quickcheck-based test, and otherwise this PR should only affect linkage (not runtime), so I'm going to retry assuming it's spurious. If this lands I'll open an issue upstream.

@bors: retry

bors · 2017-10-20T23:08:24Z

⌛ Testing commit 3541ffb with merge 6511b4f...

rustc: Add `_imp_` symbols later in compilation On MSVC targets rustc will add symbols prefixed with `_imp_` to LLVM modules to "emulate" dllexported statics as that workaround is still in place after #27438 hasn't been solved otherwise. These statics, however, were getting gc'd by ThinLTO accidentally which later would cause linking failures. This commit updates the location we add such symbols to happen just before codegen to ensure that (a) they're not eliminated by the optimizer and (b) the optimizer doesn't even worry about them. Closes#45347

bors · 2017-10-21T01:59:38Z

☀️ Test successful - status-appveyor, status-travis
Approved by: michaelwoerister
Pushing 6511b4f to master...

This fixes a flaky test which caused spurious failures in rust-lang#45348 and rust-lang#45380

cargotest: Update xsv. This fixes a flaky test which caused spurious failures in #45348 and #45380.

rust-highfive assigned eddyb Oct 18, 2017

rust-highfive assigned michaelwoerister and unassigned eddyb Oct 18, 2017

kennytm added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 18, 2017

michaelwoerister reviewed Oct 18, 2017
View reviewed changes

alexcrichton force-pushed the thinlto-timp branch from a1fd369 to 3541ffbCompare October 18, 2017 14:01

kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 18, 2017

alexcrichton mentioned this pull request Oct 19, 2017
Tracking issue for enabling multiple CGUs in release mode by default #45320
Closed
11 tasks

kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 20, 2017

kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 20, 2017

bors merged commit 3541ffb into rust-lang:masterOct 21, 2017

bors mentioned this pull request Oct 21, 2017
rustc: Move bytecode compression into codegen #45399
Merged

kennytm mentioned this pull request Oct 26, 2017
Avoid unnecessary copies of arguments that are simple bindings #45380
Merged

kennytm added a commit to kennytm/rust that referenced this pull request Oct 26, 2017
cargotest: Update xsv.
bea5ed6
This fixes a flaky test which caused spurious failures in rust-lang#45348 and rust-lang#45380

kennytm mentioned this pull request Oct 26, 2017
cargotest: Update xsv. #45550
Merged

alexcrichton deleted the thinlto-timp branch October 28, 2017 12:56

bors added a commit that referenced this pull request Oct 31, 2017
Auto merge of#45550- kennytm:update-xsv, r=BurntSushi
f57c55d
cargotest: Update xsv. This fixes a flaky test which caused spurious failures in #45348 and #45380.

kennytm mentioned this pull request Jan 5, 2018
Rollup of 10 pull requests #47195
Closed

ollie27 mentioned this pull request Mar 15, 2020
Regenerate tables for Unicode 13.0.0 #69929
Merged

Uh oh!

Uh oh!

Conversation

alexcrichton commented Oct 18, 2017

Uh oh!

rust-highfive commented Oct 18, 2017

Uh oh!

alexcrichton commented Oct 18, 2017

Uh oh!

michaelwoerister left a comment

Choose a reason for hiding this comment

Uh oh!

michaelwoeristerOct 18, 2017

Choose a reason for hiding this comment

Uh oh!

alexcrichton commented Oct 18, 2017

Uh oh!

bors commented Oct 18, 2017

Uh oh!

bors commented Oct 20, 2017

Uh oh!

bors commented Oct 20, 2017

Uh oh!

kennytm commented Oct 20, 2017

Uh oh!

alexcrichton commented Oct 20, 2017

Uh oh!

alexcrichton commented Oct 20, 2017

Uh oh!

bors commented Oct 20, 2017

Uh oh!

bors commented Oct 21, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants