Uh oh!
There was an error while loading. Please reload this page.
Correct misspelling in error text: re-assignment => reassignment - #45398
Merged
Conversation
rust-highfive
commented
Oct 20, 2017
Contributor
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
MemberAuthor
pinging on my own PR but it's what the triage procedures say sooo ping @arielb1! |
arielb1
commented
Oct 23, 2017
Contributor
This won't cause any stability problems - there are no stability promises on error messages. However, I'm not sure this is an improvement. assignment is the technical term, so I think re-assignment is preferrable to the somewhat distinct word reassignment. |
kennytm
commented
Oct 25, 2017
Member
So, should this PR go forward or should this be closed? |
carols10cents
commented
Oct 25, 2017
MemberAuthor
I think we've come up with a compromise :) |
arielb1
commented
Oct 25, 2017
Contributor
@bors r+ rollup |
bors
commented
Oct 25, 2017
Collaborator
📌 Commit 0e46cf4 has been approved by |
kennytm added a commit
to kennytm/rust
that referenced
this pull request
Oct 25, 2017
Correct misspelling in error text: re-assignment => reassignment [reassignment is the correct spelling](https://www.thefreedictionary.com/reassignment) rather than re-assignment; this error message looks silly in the book next to text trying to be grammatically correct :-/ Will this cause any stability/backcompat type issues?
bors added a commit
that referenced
this pull request
Oct 25, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reassignment is the correct spelling rather than re-assignment; this error message looks silly in the book next to text trying to be grammatically correct :-/
Will this cause any stability/backcompat type issues?