rustbuild: don't try to install rls if ToolState is not Testing

[Keruspe]

We already do that for the Dist Step so we would end up trying to install something that we didn't dist.

[rust-highfive]

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

[shepmaster]

r? @alexcrichton

[alexcrichton]

Thanks! Could this use the return value of ensure to dispatch though?

[Keruspe]

Sure, I just naively did the same as in the Dist phase.

[Keruspe]

I'm wondering, should we just split the block in two macro parameters, the first one being the dist step we depend on and the second one being the actual install_foo call?
This way we could add the check for the return value of ensure in the common boilerplate and it would be automatically handled once other tools listed in toolstate can be installed.

edit: looks like ensure doesn't return the same type for all the steps (PathBuf VS Option<PathBuf>), that's a bummer

[Keruspe]

@alexcrichton FYI, in case I made it unclear, I amended my initial commit with your suggestion

[alexcrichton]

@bors: r+

Thanks!

[bors]

📌 Commit 784528b has been approved by alexcrichton

[bors]

⌛ Testing commit 784528b with merge 31040922a2f540ccc5293596559b4f4ae5eeae8a...

[kennytm]

@bors retry — prioritizing rollup