Add test for #44953

[virgil-palanciuc]

Added the requested test - trying to see if it passes; my local build fails, but not sure why - the nightly shows this output, but in my build the compilation error changed.

Fixes#44953.

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[alexcrichton]

@bors: r+

Thanks!

[bors]

📌 Commit f29d7ca has been approved by alexcrichton

[kennytm]

@bors r-

CI failed, see #44953 (comment).

[jakubadamw]

@virgil-palanciuc, in my opinion the way to go would be to write a complete ui-fulldeps test, so as not to rely on the log crate's rustc_private attribute. Essentially, have an auxiliary crate with the rustc_private configuration attribute (see here) and a test that tries to use it without a #[feature(rustc_private)] attribute. But someone else should also comment if that sounds sensible.

[virgil-palanciuc]

I will try to do so today. Sorry for the delay, I've been traveling + had a few busy days.
[edit] Well, I under-estimated the task - turns out I need to understand macros better. Will attempt again during weekend.

[shepmaster]

Heya @virgil-palanciuc — we haven't heard from you in a week or so! Will you have time soon to address the feedback?

[virgil-palanciuc]

I'm trying, I just have very limited time right now (especially during the week), and the test proved to be harder then I expected (it's probably not THAT hard, but my rust knowledge is limited, especially around macros ). I hope I can allocate a few hours tomorrow to try again.

If anyone wants to/ can add this test faster than I can, I don't mind - I don't want to hold you guys back. It's mostly a learning exercise for me :)

[shepmaster]

I just have very limited time right now

That's totally fine, just give us a little status ping every week or so (or we will give you one 😈) to let us know it's still in progress! Thanks!

[virgil-palanciuc]

Turns out, the solution I had attempted was overly-complicated (I attempted a partial recreation of the log crate inside ui-fulldeps - and, while trying to make that work, I ended up realizing it was totally unnecessary). I tested that the test works with current implementation and fails without previous bugfix, so, hopefully all good.

I'm going to take a pause from contributing right now, as I realized it takes more time than I currently have; but I hope I'll be able to come back. Gotta say, I'm blown away by the friendliness of this community and how much effort you guys put in to "onboard" new members. Kudos for that.

[kennytm]

@bors r+ rollup

Thanks for the hard work @virgil-palanciuc !

[bors]

📌 Commit 2ab9742 has been approved by kennytm

[kennytm]

@virgil-palanciuc Hi, I just noticed that this PR itself contains a merge commit. Could you rebase and squash everything into a single commit? Thanks.

[virgil-palanciuc]

@kennytm Hopefully it's ok now, let me know if I need to do anything else.

[kennytm]

Thanks again!

@bors r+

[bors]

📌 Commit a38586d has been approved by kennytm

[kennytm]

@virgil-palanciuc Sorry needs to bother this again. Due to recent merge of #45545, the UI test output is changed causing your test no longer pass. Please rebase the PR and apply the following diff to the .stderr file:

 error: use of unstable library feature 'rustc_private': this crate is being loaded from the sysroot, an unstable location; did you mean to load this crate from crates.io via `Cargo.toml` instead? (see issue #27812)
--> $DIR/issue-44953.rs:16:14
|
16 | #[macro_use] extern crate log;
| ^^^^^^^^^^^^^^^^^
|
= help: add #![feature(rustc_private)] to the crate attributes to enable
error: use of unstable library feature 'rustc_private': this crate is being loaded from the sysroot, an unstable location; did you mean to load this crate from crates.io via `Cargo.toml` instead? (see issue #27812)
--> $DIR/issue-44953.rs:19:5
|
19 | info!("This is a log message.");
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: add #![feature(rustc_private)] to the crate attributes to enable
- = note: this error originates in a macro outside of the current crate+ = note: this error originates in a macro outside of the current crate (run with -Z external-macro-backtrace for more info)
error: aborting due to 2 previous errors

@bors r-

[virgil-palanciuc]

This one just doesn't want to get closed, does it?
I pushed the updated output, rebased on top of origin/master, tested that it works - let's see what else comes up 😆

[kennytm]

@bors r+

[bors]

📌 Commit a2d63d6 has been approved by kennytm