Uh oh!
There was an error while loading. Please reload this page.
Allow overriding the TLS model - #45666
Conversation
rust-highfive
commented
Oct 31, 2017
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
Amanieu
commented
Nov 2, 2017
At the moment |
Amanieu
commented
Nov 3, 2017
Ok, I'm now caching the parsed TLS model in the crate context. This PR is ready for merging. |
carols10cents
commented
Nov 6, 2017
michaelwoerister
commented
Nov 6, 2017
I think @alexcrichton is more qualified to review this. |
alexcrichton
commented
Nov 6, 2017
I don't really know what a TLS model is but it seems fine to expose for now. Can this be placed behind feature gates, however, to require nightly and go through the normal stabilization process? |
Amanieu
commented
Nov 6, 2017
I don't think we have a mechanism for putting a target json attribute under a feature gate. |
Amanieu
commented
Nov 6, 2017
Also, how do I mark a -C option as unstable? |
alexcrichton
commented
Nov 6, 2017
That's ok to leave the target json as-is, those are "pretty unstable" as-is anyway. For the options you can move it to |
Amanieu
commented
Nov 6, 2017
Done |
alexcrichton
commented
Nov 7, 2017
@bors: r+ |
bors
commented
Nov 7, 2017
📌 Commit fdf7ba2 has been approved by |
bors
commented
Nov 7, 2017
Allow overriding the TLS model This PR adds the ability to override the default "global-dynamic" TLS model with a more specific one through a target json option or a command-line option. This allows for better code generation in certain situations. This is similar to the `-ftls-model=` option in GCC and Clang.
bors
commented
Nov 7, 2017
☀️ Test successful - status-appveyor, status-travis |
This PR adds the ability to override the default "global-dynamic" TLS model with a more specific one through a target json option or a command-line option. This allows for better code generation in certain situations.
This is similar to the
-ftls-model=option in GCC and Clang.