Skip to content

[WIP] ci: Enable RUST_BACKTRACE=1 - #45693

Closed
kennytm wants to merge 4 commits into
rust-lang:masterfrom
kennytm:enable-backtrace-on-ci
Closed

[WIP] ci: Enable RUST_BACKTRACE=1#45693
kennytm wants to merge 4 commits into
rust-lang:masterfrom
kennytm:enable-backtrace-on-ci

Conversation

@kennytm

Copy link
Copy Markdown
Member
  1. Enable RUST_BACKTRACE=1 when building (but not testing).
  2. Re-enable debug and LLVM assertions for macOS dist builds (they remain disabled in check builds).

WIP — checking if slowdown is within acceptable range (≤2 hours to complete).

@kennytmkennytm added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 1, 2017
@kennytm

kennytm commented Nov 1, 2017

Copy link
Copy Markdown
MemberAuthor

For record:

Imagemasterassertionsno debug
x86_64-gnu-llvm-3.91h 16m 14s1h 31m 44s1h 10m 3s
check i686-apple-darwin2h 40m 36s2h 40m 56s2h 50m 56s
dist i686-apple-darwin1h 53m 43s2h 34m 58s2h 45m 49s
dist x86_64-apple-darwin2h 20m 07s----
dist-s390x-linux1h 39m 53s1h 32m 49s1h 41m 58s
x86_64-gnu-full-bootstrap1h 06m 10s1h 27m 48s1h 08m 19s

Looks like the impact from debug/LLVM assertions are still huge, and enabling RUST_BACKTRACE=1 for Macs will push them very close to the 3 hr line.

Will try disable RUST_BACKTRACE=1 for macs entirely next.

@kennytm

Copy link
Copy Markdown
MemberAuthor

Waiting for #45783. Closing for now.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@kennytm