Uh oh!
There was an error while loading. Please reload this page.
ci: Fix broken link in build-powerpc64le-toolchain.sh - #45734
Conversation
kennytm
commented
Nov 3, 2017
Or we could cache those files in our S3 again... |
alexcrichton
commented
Nov 3, 2017
@bors: r+ p=100 |
bors
commented
Nov 3, 2017
📌 Commit 1f95c6d has been approved by |
bors
commented
Nov 3, 2017
ci: Fix broken link in `build-powerpc64le-toolchain.sh` r? @rust-lang/infra This is just an emergency fix to keep bors running for another week. I think the numbers will be broken soon. Can we verify if this statement is still true later? > First, download the CentOS7 glibc.ppc64le and relevant header files. > (upstream ppc64le support wasn't added until 2.19, which el7 backported.)
kennytm
commented
Nov 3, 2017
cc @cuviper |
kennytm
commented
Nov 3, 2017
Looks like we could use the URL http://vault.centos.org/altarch/7.3.1611/os/ppc64le/Packages/ as well, if we absolutely want to stay on the same Centos version. |
bors
commented
Nov 3, 2017
☀️ Test successful - status-appveyor, status-travis |
cuviper
commented
Nov 3, 2017
@kennytm As long as the basic glibc and kernel versions are the same, our compatibility won't be affected. Bumping to newer package releases shouldn't change ABI at all. In any case, using a vault link does seem like a better idea for longevity.
I'm not sure what you're asking to verify -- it's just a fact that el7 backported ppc64le support. |
kennytm
commented
Nov 3, 2017
@cuviper I see. I asked because the ppc64 script looks much simpler and doesn't download anything ^^ @alexcrichton So for the backport to beta we'll switch to http://vault.centos.org/altarch/7.3.1611/os/ppc64le/Packages/ instead of reusing this PR. I'll submit another PR for master using the vault link as well? |
cuviper
commented
Nov 3, 2017
Yeah, ppc64(be) has been around much longer and doesn't need special backports, so for that we just use plain upstream versions via crosstool-ng. |
[beta] ci: Fix broken link in `build-powerpc64le-toolchain.sh` This is almost a backport of #45734, but uses vault.centos.org instead for better longevity. r? @alexcrichton cc @cuviper
This commit reverts rust-lang#45734 and applies rust-lang#45744. We expect the vault links to be more stable than mirror.centos.org.
r? @rust-lang/infra
This is just an emergency fix to keep bors running for another week. I think the numbers will be broken soon. Can we verify if this statement is still true later?