Highlight code on diagnostics when underlined

[estebank]

Highlight the label's span with the respective color:

Fix#42112.

[rust-highfive]

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

[estebank]

Don't merge yet, needs a quick code change yet.

[nikomatsakis]

@estebank I'm trying to remember why we stopped highlighting the code examples with color, but I cannot. In any case, the examples where there are overlapping spans look...odd to my eye. I wish we had a more elegant way of handling that. I feel like I would prefer if the underlines were drawn on different lines. This is to some extent a distinct issue, but the color makes it more noticeable to me. =)

[durka]

What's with the random blue highlighting in some examples? In the first one, // s and the last one, } => {} // seems highlighted for no reason.

[estebank]

What's with the random blue highlighting in some examples? In the first one, // s and the last one, } => {} // seems highlighted for no reason.

@durka because of a mistake I made, it's inserting style at position instead of actually replacing, making the output of overlapping spans incorrect, as you see in that screenshot. I didn't notice it until I published the PR :)

I'm trying to remember why we stopped highlighting the code examples with color, but I cannot.

Neither can I :-/

In any case, the examples where there are overlapping spans look...odd to my eye. I wish we had a more elegant way of handling that. I feel like I would prefer if the underlines were drawn on different lines. This is to some extent a distinct issue, but the color makes it more noticeable to me. =)

As for the weirdness around overlapping spans, I feel that 1) it'd get sidestepped by highlighting with bold only (it'd just point towards region without carrying any info about the span type, that'd be only in the underline, so we end up in the same place as today), and 2) even beyond the weirdness of having differently colored code and underline is that it is one way of actually carrying information on where at least one of the spans actually starts without having multiple lines dedicated to the overlapping underlines, but it does look slightly weird. Even if we make the overlapping underlines appear in different lines we're back to really ugly output for thin terminals seen in #42112.

[estebank]

Alternative PR #45776 that doesn't use color, only highlights both primary and secondary spans.

[estebank]

Moving this to r? @nikomatsakis so that he's the reviewer for both alternative PRs.

[nikomatsakis]

I think there is general consensus that if we were to do anything, it would be #45776, right? Maybe we can close this one?

[estebank]

Closing.

[nikomatsakis]

Based on our recent conversation, maybe this is still on the table?

[estebank]

@nikomatsakis yes, let's keep it around.

[carols10cents]

Triage ping! What's the status of this and #45776? The discussion on users seems to be pretty quiet too, do we need to try and get this more attention?

[estebank]

@carols10cents, I think @nikomatsakis and I lean towards merging this one, but I'd like to get some support to disable it in some way before doing so.

[shepmaster]

Sounds like @estebank has some more work to do before we'd be happy merging, yeah?

[nikomatsakis]

@estebank I say let's do it. We can always back off.

[nikomatsakis]

Well, I guess I agree with the idea that we should make it configurable. The time has come, I guess.

[shepmaster]

@estebank ping from triage — will you have some time to make this configurable?

[estebank]

@shepmaster I will try to have something before the end of the year.

[estebank]

@nikomatsakis I started playing with using serde and toml to add a $HOME/.rustc configuration file. As it uses serde_derive the compilation fails late in stage 1 failing to find proc_macro, but otherwise it works well. I will try later to see if I can implement the Deserializer for the config. Is it ok to bring these deps into rustc?

You can take a look at the code (broken at the moment) if you want to see the general approach I took.

[nikomatsakis]

Is it ok to bring these deps [serde] into rustc?

cc @alexcrichton@eddyb @rust-lang/compiler -- seems ok to me in principle. I'm not sure if there are technical complications.

[estebank]

@nikomatsakis, rebased and gated it on -Zteach, as I believe it makes sense to do so.

[nikomatsakis]

good enough for now!

@bors r+

[bors]

📌 Commit 08287c1 has been approved by nikomatsakis

[bors]

⌛ Testing commit 08287c1 with merge 9712a3319ba284f218145d17a162b150d896623d...

[bors]

💔 Test failed - status-appveyor

[kennytm]

@bors retry

3 hour timeout on check-aux x86_64-pc-windows-msvc

[bors]

⌛ Testing commit 08287c1 with merge 8ffa119abdc6290be864cad373cd4f7c1a16f76e...

[bors]

💔 Test failed - status-appveyor

[kennytm]

@bors retry #46903

[bors]

⌛ Testing commit 08287c1 with merge ee8dbd216863f3715fbf98ccaf089afa713ae737...

[bors]

💔 Test failed - status-appveyor

[estebank]

I'll try one more time

@bors retry

[bors]

⌛ Testing commit 08287c1 with merge 560a2f4...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 560a2f4 to master...