Skip to content

change MIR dump filenames from rustc.nodeN... to rustc.<DefPath> - #45757

Merged
bors merged 2 commits into
rust-lang:masterfrom
mikhail-m1:change-mir-dump-filename
Nov 9, 2017
Merged

change MIR dump filenames from rustc.nodeN... to rustc.<DefPath>#45757
bors merged 2 commits into
rust-lang:masterfrom
mikhail-m1:change-mir-dump-filename

Conversation

@mikhail-m1

@mikhail-m1mikhail-m1 commented Nov 4, 2017

Copy link
Copy Markdown
Contributor

nikomatsakis
nikomatsakis reviewed Nov 4, 2017
View reviewed changes
Comment threadsrc/librustc/hir/map/definitions.rs Outdated

@nikomatsakisnikomatsakisNov 4, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: maybe use -? I sort of like that the . in the current filename allows us to "group" (e.g., rustc.foo-bar.before.mir can be split on . to get out the various bits of information about what this is a dump of)

@kennytmkennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 4, 2017
@nikomatsakis

nikomatsakis commented Nov 6, 2017

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Nov 6, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 4a482e9 has been approved by nikomatsakis

@kennytmkennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2017
@sinkuusinkuu mentioned this pull request Nov 8, 2017
Merged
@sinkuu

sinkuu commented Nov 9, 2017

Copy link
Copy Markdown
Contributor

@mikhail-m1 You may need a rebase since a new mir test (src/test/mir-opt/nll/named-lifetimes-basic.rs) has been added in master.

@mikhail-m1
mikhail-m1force-pushed the change-mir-dump-filename branch from 4a482e9 to 0e5c95eCompareNovember 9, 2017 09:37
@nikomatsakis

nikomatsakis commented Nov 9, 2017

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Nov 9, 2017

Copy link
Copy Markdown
Collaborator

📌 Commit 0e5c95e has been approved by nikomatsakis

@bors

bors commented Nov 9, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 0e5c95e with merge bdb03322cb03b767b35f945799fdd30b065333ac...

@bors

bors commented Nov 9, 2017

Copy link
Copy Markdown
Collaborator

💔 Test failed - status-travis

@kennytm

kennytm commented Nov 9, 2017

Copy link
Copy Markdown
Member

@bors retry — travis-ci/travis-ci#8728

@bors

bors commented Nov 9, 2017

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 0e5c95e with merge d6b06c6...

bors added a commit that referenced this pull request Nov 9, 2017
@bors
Auto merge of#45757- mikhail-m1:change-mir-dump-filename, r=nikomat…
d6b06c6
…sakis
change MIR dump filenames from `rustc.nodeN...` to `rustc.<DefPath>`
r? @nikomatsakis
@bors

bors commented Nov 9, 2017

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing d6b06c6 to master...

@bors
bors merged commit 0e5c95e into rust-lang:masterNov 9, 2017
This was referenced Nov 9, 2017
Closed
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikomatsakisnikomatsakisnikomatsakis left review comments

Assignees

@nikomatsakisnikomatsakis

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mikhail-m1@nikomatsakis@bors@sinkuu@kennytm