Uh oh!
There was an error while loading. Please reload this page.
Update LLVM to fix miscompiles with -Copt-level=z on Windows - #45824
Conversation
dotdash
commented
Nov 7, 2017
Needs to wait for rust-lang/llvm#95 |
alexcrichton
commented
Nov 7, 2017
r=me with the new merge commit, also would it be possible to add a test for this? |
dotdash
commented
Nov 7, 2017
If someone could test that this crashes on i686 windows msvc with -Copt-level=z #![feature(test)]externcrate test;fnfoo(x:i32,y:i32) -> i64{(x + y)asi64}#[inline(never)]fnbar(){let f = Box::new(0);let y:fn(i32,i32) -> i64 = test::black_box(foo);
test::black_box(y(1,2));}fnmain(){bar();} |
nagisa
commented
Nov 7, 2017
The test from the comment above does crash on 11-03 nightly. Compiling it complains about |
nagisa
commented
Nov 7, 2017
That being said, I feel that a codegen test would be way more appropriate if one is possible. |
dotdash
commented
Nov 8, 2017
Are there any codegen tests that check for assembler output? |
dotdash
commented
Nov 8, 2017
Doesn't seem like there is, and I currently don't have time to adjust the test runner to support it. :-/ So this is free for someone to pick up. |
alexcrichton
commented
Nov 8, 2017
Er sorry @dotdash I didn't mean to imply a test was required, just if we already had one I figured it'd be good to include! I'm totally fine merging this regardless (as it's upstream in LLVM anyway). Do you want to check in the test you gisted above and r=me? |
dotdash
commented
Nov 8, 2017
@bors r=alexcrichton |
bors
commented
Nov 8, 2017
📌 Commit 8b6caa2 has been approved by |
kennytm
commented
Nov 10, 2017
@bors r- CI failed, “error: -O and -C opt-level both provided” on the new test case. Details |
nagisa
commented
Nov 10, 2017
Sadly, using |
bors
commented
Nov 11, 2017
☔ The latest upstream changes (presumably #45806) made this pull request unmergeable. Please resolve the merge conflicts. |
dotdash
commented
Nov 12, 2017
@bors r=alexcrichton |
bors
commented
Nov 12, 2017
📌 Commit 1a8c9f8 has been approved by |
bors
commented
Nov 13, 2017
Update LLVM to fix miscompiles with -Copt-level=z on Windows Fixes#45034
bors
commented
Nov 13, 2017
☀️ Test successful - status-appveyor, status-travis |
Fixes#45034