Uh oh!
There was an error while loading. Please reload this page.
Warn about lack of args glob expansion in Windows shell - #45830
Merged
Conversation
rust-highfive
commented
Nov 7, 2017
Contributor
r? @dtolnay (rust_highfive has picked a reviewer for you, use r? to override) |
dtolnay
reviewed
Nov 7, 2017
dtolnay
left a comment
Member
There was a problem hiding this comment.
Thanks! Seems good to me once the spelling is correct.
dtolnay
commented
Nov 7, 2017
Member
@bors r+ rollup |
bors
commented
Nov 7, 2017
Collaborator
📌 Commit 53de42e has been approved by |
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 8, 2017
Warn about lack of args glob expansion in Windows shell Because all shells on Linux/macOS expand globs, and even MinGW on Windows emulates this behavior, it's easy to forget that Windows by itself doesn't support glob expansion. This PR documents this cross-platform difference.
bors
commented
Nov 8, 2017
Collaborator
☔ The latest upstream changes (presumably #45862) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because all shells on Linux/macOS expand globs, and even MinGW on Windows emulates this behavior, it's easy to forget that Windows by itself doesn't support glob expansion. This PR documents this cross-platform difference.